Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net,stream: remove DuplexBase #19779

Closed
wants to merge 2 commits into from
Closed

net,stream: remove DuplexBase #19779

wants to merge 2 commits into from

Commits on Apr 3, 2018

  1. net,stream: remove DuplexBase 

    `DuplexBase` was added to prevent the "no-half-open enforcer" from
being inherited by `net.Socket`. The main reason to use it instead
of `Duplex` was that it allowed to not copy the options object but
since commit 5e3f516 the options object is copyed anyway so it is
no longer useful.
    @lpinca
    lpinca committed Apr 3, 2018
    Configuration menu
    Copy the full SHA
    82b72c8 View commit details
    Browse the repository at this point in the history

  2. fixup! net,stream: remove DuplexBase

    @lpinca
    lpinca committed Apr 3, 2018
    Configuration menu
    Copy the full SHA
    5c397d9 View commit details
    Browse the repository at this point in the history