Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dns: consistently add hostname #19754

Closed
wants to merge 1 commit into from
Closed

dns: consistently add hostname #19754

wants to merge 1 commit into from

Conversation

BridgeAR
Copy link
Member

@BridgeAR BridgeAR commented Apr 2, 2018

Right now the hostname could in some cases be missed, depending on
the libuv error number. This makes sure there the hostname is always
added, if available.

This currently relies on #19719 and I am
going to rebase the PR as soon as that lands.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@BridgeAR BridgeAR added the blocked PRs that are blocked by other issues or PRs. label Apr 2, 2018
@nodejs-github-bot nodejs-github-bot added dns Issues and PRs related to the dns subsystem. errors Issues and PRs related to JavaScript errors originated in Node.js core. labels Apr 2, 2018
@BridgeAR BridgeAR added the semver-major PRs that contain breaking changes and should be released in the next major version. label Apr 2, 2018
@BridgeAR
errors: make dns errors consistent
8050427 
Right now the hostname could in some cases be missed, depending on
the libuv error number. This makes sure there the hostname is always
added, if available.
@BridgeAR
Copy link
Member Author

BridgeAR commented Apr 5, 2018

CI https://ci.nodejs.org/job/node-test-pull-request/14075/

@BridgeAR BridgeAR removed the blocked PRs that are blocked by other issues or PRs. label Apr 5, 2018
@BridgeAR BridgeAR requested a review from a team April 5, 2018 16:04
@jasnell jasnell changed the title dns: constistently add hostname dns: consistently add hostname Apr 5, 2018
mcollina
mcollina approved these changes Apr 5, 2018
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

BridgeAR added a commit to BridgeAR/node that referenced this pull request Apr 5, 2018
@BridgeAR
errors: make dns errors consistent
b29c36b 
Right now the hostname could in some cases be missed, depending on
the libuv error number. This makes sure there the hostname is always
added, if available.

PR-URL: nodejs#19754
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@BridgeAR
Copy link
Member Author

BridgeAR commented Apr 5, 2018

Landed in b29c36b

@BridgeAR BridgeAR closed this Apr 5, 2018
@BridgeAR BridgeAR deleted the add-hostname branch April 1, 2019 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joyeecheung joyeecheung joyeecheung approved these changes

@jasnell jasnell jasnell approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
dns Issues and PRs related to the dns subsystem. errors Issues and PRs related to JavaScript errors originated in Node.js core. semver-major PRs that contain breaking changes and should be released in the next major version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@BridgeAR @mcollina @jasnell @joyeecheung @nodejs-github-bot