Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v8.x backport] 16390, 18547, 17296 (internet test flake fixes) #19706

Closed
wants to merge 5 commits into from
Closed

[v8.x backport] 16390, 18547, 17296 (internet test flake fixes) #19706

wants to merge 5 commits into from

Commits on Mar 30, 2018

  1. test: introduce test/common/internet.addresses 

    This commit introduces test/common/internet.address, which
includes a set of addresses for doing internet tests.
These addresses can be overriden using NODE_TEST_* environment
variables.

PR-URL: nodejs#16390
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
    @joyeecheung
    joyeecheung committed Mar 30, 2018
    Configuration menu
    Copy the full SHA
    239c02d View commit details
    Browse the repository at this point in the history

  2. test: use internet.addresses in internet tests 

    PR-URL: nodejs#16390
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
    @joyeecheung
    joyeecheung committed Mar 30, 2018
    Configuration menu
    Copy the full SHA
    9fb711a View commit details
    Browse the repository at this point in the history

  3. test: do not check TXT content in test-dns-any 

    google.com added another TXT record which broke this test.
This removes the check on the content of the TXT record
since that depends on an external state subject to change.

PR-URL: nodejs#18547
Reviewed-By: Khaidi Chu <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: James M Snell <[email protected]>
    @joyeecheung
    joyeecheung committed Mar 30, 2018
    Configuration menu
    Copy the full SHA
    f969be6 View commit details
    Browse the repository at this point in the history

  4. test: add common.dns.errorLookupMock 

    PR-URL: nodejs#17296
Refs: nodejs/help#687
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
    @joyeecheung
    joyeecheung committed Mar 30, 2018
    Configuration menu
    Copy the full SHA
    fde95ff View commit details
    Browse the repository at this point in the history

  5. test: mock the lookup function in parallel tests 

    These tests should not make any DNS calls. The lookup would fail
when the DNS requests are hijacked and time out instead of erroring
out.

PR-URL: nodejs#17296
Refs: nodejs/help#687
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
    @joyeecheung
    joyeecheung committed Mar 30, 2018
    Configuration menu
    Copy the full SHA
    d989b20 View commit details
    Browse the repository at this point in the history