Suppresses the runtime/sizeof cpplint error using Ben's suggestion via t...

[rudi-cilibrasi]

...he NOLINT directive.

[bnoordhuis]

LGTM but can you update the commit log to conform to the template from CONTRIBUTING.md? Cheers.

[cjihrig]

This has moved to #202.

@rudi-cilibrasi you're able to update an existing PR. No need to open a new PR for every change.

[rudi-cilibrasi]

Thanks Colin. I hope you don't mind a question related to this about git.
I am curious because I need to learn some more convenient ways to
collaborate in git. I can get by but I frequently wind up cloning the
whole repo all over just to get a clean commit. I was not sure how I could
update a commit log message without leaving a small mess (old commit still
there) without starting a new PR. I thought that --amend might be the only
way to do it however I wanted to find out if there might be another way?
I've used --amend to fix my name/email before but have not used it to fix
the commit log although it seems like a good fit.

On Tue, Dec 23, 2014 at 8:12 AM, Colin Ihrig [email protected]
wrote:

This has moved to #202 #202.

@rudi-cilibrasi https://github.com/rudi-cilibrasi you're able to update
an existing PR. No need to open a new PR for every change.

—
Reply to this email directly or view it on GitHub
#197 (comment).

Happy to Code with Integrity : Software Engineering Code of Ethics and
Professional Practice http://www.acm.org/about/about/se-code

[cjihrig]

Yes, git commit --amend would have been a good way to solve this problem. That would allow you to reword the commit message as Ben requested. Then you could do a force push up to your feature branch.

[bnoordhuis]

@rudi-cilibrasi Also git rebase -i <tree-ish> to squash, reword or remove commits. CONTRIBUTING.md in the top-level directory goes into detail.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/28931/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/28946/