tools: update ESLint to 4.19.1 #19528
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
lib / src
targos
approved these changes
Mar 22, 2018
danbev
approved these changes
Mar 22, 2018
cjihrig
approved these changes
Mar 22, 2018
trivikr
reviewed
Mar 22, 2018
lib/internal/readline.js
Outdated
| const ansi = | ||
| /[\u001b\u009b][[()#;?]*(?:[0-9]{1,4}(?:;[0-9]{0,4})*)?[0-9A-ORZcf-nqry=><]/g; | ||
| /* eslin-enable no-control-regex */ |
ESLint 4.19.1 fixes some bugs in rules. These changes prepare us for the upgrade.
A few bug fixes result in more stringent linting rules.
trivikr
approved these changes
Mar 22, 2018
Trott
added
the
author ready
jasnell
approved these changes
Mar 23, 2018
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Mar 24, 2018
ESLint 4.19.1 fixes some bugs in rules. These changes prepare us for the upgrade. PR-URL: nodejs#19528 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]>
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Mar 24, 2018
A few bug fixes result in more stringent linting rules. PR-URL: nodejs#19528 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]>
|
Landed in 2289267...0863a0e |
targos
removed
the
author ready
targos
pushed a commit
that referenced
this pull request
Mar 27, 2018
ESLint 4.19.1 fixes some bugs in rules. These changes prepare us for the upgrade. PR-URL: #19528 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos
pushed a commit
that referenced
this pull request
Mar 27, 2018
A few bug fixes result in more stringent linting rules. PR-URL: #19528 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few bug fixes result in more stringent linting rules.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes