Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cluster: do not unconditionally set --debug-port #1949

Merged
merged 1 commit into from
Jun 17, 2015
Merged

cluster: do not unconditionally set --debug-port #1949

merged 1 commit into from
Jun 17, 2015

Commits on Jun 17, 2015

  1. cluster: do not unconditionally set --debug-port 

    Currently, each cluster worker is assigned an ever increasing
--debug-port argument. A long running cluster application that
does not use the debugger can run into errors related to the
port range. This commit mitigates the problem by only setting
the debug port if the master is started with debug arguments, or
the user explicitly defines debug arguments for the worker. This
commit also adds a new debug port offset counter that is only
incremented when a worker is created that utilizes debugging.

Fixes: nodejs/node-v0.x-archive#8159
Refs: #1524
PR-URL: #1949
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Oleg Elifantiev <[email protected]>
    @cjihrig
    cjihrig committed Jun 17, 2015
    Configuration menu
    Copy the full SHA
    309c0f4 View commit details
    Browse the repository at this point in the history