Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add note about browsers and HTTP/2 #19476

Closed
wants to merge 5 commits into from
Closed

doc: add note about browsers and HTTP/2 #19476

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b19e4da
docs: add note about browsers and HTTP/2
styfle Mar 20, 2018
f26470d
docs: fix hyperlink to http2 unencrypted
styfle Mar 20, 2018
9796ce3
doc: fix name of link
styfle Mar 20, 2018
c83205d
doc: update comments
styfle Mar 20, 2018
7d2ff38
doc: fix md hyperlink
styfle Mar 20, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions doc/api/http2.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,9 @@ be emitted either by client-side code or server-side code.

### Server-side example

The following illustrates a simple, plain-text HTTP/2 server using the
Core API:
The following illustrates a simple HTTP/2 server using the Core API.
Note the use of [`http2.createSecureServer()`][] since HTTPS is required
for [most web browsers](https://caniuse.com/#feat=http2).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No browsers support unencrypted HTTP2 (HTTP/2 spec FAQ)
You can change this to "since no browsers support unencrypted HTTP2" with the link to HTTP/2 spec FAQ

Ditto for line 1735


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say something like...

Since there are no browsers known that support [unencrypted HTTP/2](HTTP/2 Unencrypted),
the use of [`http2.createSecureServer()`][] is necessary when communicating with browser
clients.

Using Unencrypted HTTP/2 would actually be the preference when running purely within internal environments with non-browser clients.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okie dokie 👍

```js
const http2 = require('http2');
Expand Down Expand Up @@ -252,7 +253,7 @@ and would instead register a handler for the `'stream'` event emitted by the
```js
const http2 = require('http2');

// Create a plain-text HTTP/2 server
// Create a simple HTTP/2 server
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the term plain-text is more specific.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about using the term unencrypted over plain-text?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd be good with that.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me 👍

const server = http2.createServer();

server.on('stream', (stream, headers) => {
Expand Down Expand Up @@ -1730,7 +1731,9 @@ instances.
```js
const http2 = require('http2');

// Create a plain-text HTTP/2 server
// Create a simple HTTP/2 server
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you restore this to plain-text?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed to unencrypted

// This will not work in most browsers,
// Try http2.createSecureServer instead
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A nit: // Try -> // try after the comma above?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any thoughts on usage of periods . anywhere?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's see what others think, I am not a native speaker)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added periods.

const server = http2.createServer();

server.on('stream', (stream, headers) => {
Expand Down