doc: add text showing that stackoverflow is not managed or moderated … #19416

JosephLeon · 2018-03-17T17:12:49Z

Checklist

documentation is changed or added
commit message follows commit guidelines

Trott

Hi @JosephLeon! Thanks for the pull request! I'm not sure what the best way to document this is, but I don't think having a parenthetical Not managed by Node.js here and a bold unofficial a few lines below for the IRC channel is the way to do it. At a minimum, it should be consistent.

Trott · 2018-03-17T22:22:07Z

@nodejs/documentation

Trott · 2018-03-17T22:23:12Z

Maybe the thing to do is to move this to the bullet list below (with the IRC channel) and use unofficial like we do there?

JosephLeon · 2018-03-18T00:01:45Z

Hey @Trott! I moved stack overflow to the unofficial section. I question though if it would be better to remove:

If you didn't find an answer in one of the venues above, you can:

With some heading saying this is the unofficial section and then listing IRC and StackOverflow. My reason for this is there may be more unofficial items to add in the future. Each item would need to be worded to match the above header which doesn't explain the section's content and sets a weird context to follow.

If you agree I can reword that section with some sort of unofficial header and then list IRC and StackOverflow beneath it.

Ex:

If you didn't find an answer in one of the venues above, you can search these unofficial venues:

Then we can remove the bolded unofficial from each item.

Trott

Looks good to me as is. I think it would be a little better if StackOverflow were listed first and IRC second. Ideally people would look their before posting in the IRC channel.

JosephLeon · 2018-03-18T00:22:52Z

Moved StackOverflow to be the first item.

LEQADA · 2018-03-18T00:43:46Z

README.md


 If you didn't find an answer in one of the venues above, you can:

+* View **unofficial** [questions tagged 'node.js' on StackOverflow][]


Sounds weird. Like there are official question, but these ones are unofficial.
Maybe let's move unofficial to the end? Like

View questions tagged 'node.js' on StackOverflow (unofficial)

Or

View questions tagged 'node.js' on StackOverflow (not supported by Node.js maintainers)

@JosephLeon @Trott wdty?

Yes, I agree. Maybe we should reword the heading so we don't have to find ways to embed unofficial in the items. I think the main idea we are trying to convey is that these resources aren't moderated by node.js maintainers.

If you didn't find an answer in one of the official resources above, you can search these unofficial resources which aren't supported by node.js maintainers:

I can always slap unofficial at the end of the StackOverflow line too. I'm open to ideas.

IMO your suggestion is better than the current version. Let's see what @Trott thinks though.

Sounds good to me.

(Minor nit: node.js -> Node.js. Alternatively, you could stop after unofficial resources and leave the which aren't supported by Node.js maintainers part off. Either way!)

I made the changes @Trott asked for but I'm getting a git error today when I run git push origin 19412:

To github.com:JosephLeon/node.git ! [rejected] 19412 -> 19412 (non-fast-forward) error: failed to push some refs to '[email protected]:JosephLeon/node.git' hint: Updates were rejected because the tip of your current branch is behind hint: its remote counterpart. Integrate the remote changes (e.g. hint: 'git pull ...') before pushing again. hint: See the 'Note about fast-forwards' in 'git push --help' for details.

Before that I did run:

git fetch upstream
git rebase upstream/master

Which returned Current branch 19412 is up to date.

I was able to push the latest changes using git push origin 19412 -f. Just writing this here in case I should modify my workflow.

@JosephLeon The reason you needed the -f is because rebase is destructive and creates new commits on top of master. So when you push, your code doesn't match the server. I think force push is fine in this case because you're the only one working on your branch.

benjamingr · 2018-03-18T08:21:38Z

If you'd like, I answer quite a bit on StackOverflow - and I can talk to their moderation team if we need anything actionable from them.

In general, SO is pretty well moderated in my experience.

davisjam

LGTM

Trott · 2018-03-19T13:53:39Z

Additional metadata for whoever lands this:

Fixes: #19412

JosephLeon · 2018-03-22T00:33:05Z

@Trott Is there anything else I need to do on this?

Trott · 2018-03-22T03:26:39Z

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite/287/

Fixes: nodejs#19412

Trott · 2018-03-22T03:36:08Z

Fixed lint errors (line wrap at 80 chars in the README), rebased against upstream/master, squashed down to one commit, added metadata.

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite/288/

Fixes: nodejs#19412 PR-URL: nodejs#19416 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: James M Snell <[email protected]>

Trott · 2018-03-22T03:43:53Z

Landed in 258bcb9

Welcome @JosephLeon and thanks for the contribution! 🎉

JosephLeon · 2018-03-22T17:50:24Z

@Trott So when we have a pull request out we should go to https://ci.nodejs.org/job/node-test-pull-request-lite/288/ and make any fixes as noted there? My main reason for doing this particular issue was to get used to the commit pattern with node before taking on a coding issue. I'm reading https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#ci-testing and it seems like only certain people can do this portion. Do you have any additional feedback for me?

Trott · 2018-03-22T21:38:28Z

@JosephLeon Hopefully make test (or on Windows vcbuild test) locally will find any issues, but yes, if there are issues in the CI run, then someone needs to figure out what's going on. (Unfortunately, often the problem is unrelated to the change in the pull request.) Only people in the Collaborators group (currently over 100 people, though!) can start CI jobs.

Fixes: #19412 PR-URL: #19416 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: James M Snell <[email protected]>

nodejs-github-bot added the doc Issues and PRs related to the documentations. label Mar 17, 2018

JosephLeon mentioned this pull request Mar 17, 2018

doc: mark StackOverflow as unofficial #19412

Closed

Trott requested changes Mar 17, 2018

View reviewed changes

Trott approved these changes Mar 18, 2018

View reviewed changes

LEQADA reviewed Mar 18, 2018

View reviewed changes

JosephLeon force-pushed the 19412 branch from ab64974 to ea7fce8 Compare March 18, 2018 13:08

davisjam approved these changes Mar 19, 2018

View reviewed changes

gibfahn approved these changes Mar 19, 2018

View reviewed changes

styfle approved these changes Mar 19, 2018

View reviewed changes

thefourtheye approved these changes Mar 19, 2018

View reviewed changes

ckotzbauer approved these changes Mar 19, 2018

View reviewed changes

jasnell approved these changes Mar 19, 2018

View reviewed changes

doc: move StackOverflow to unofficial section

2d12cdd

Fixes: nodejs#19412

Trott force-pushed the 19412 branch from ea7fce8 to 2d12cdd Compare March 22, 2018 03:34

Trott closed this Mar 22, 2018

BethGriggs mentioned this pull request Dec 4, 2018

v8.14.1 proposal #24832

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

doc: add text showing that stackoverflow is not managed or moderated … #19416

doc: add text showing that stackoverflow is not managed or moderated … #19416

JosephLeon commented Mar 17, 2018

Trott left a comment

Trott commented Mar 17, 2018

Trott commented Mar 17, 2018

JosephLeon commented Mar 18, 2018 •

edited

Loading

Trott left a comment

JosephLeon commented Mar 18, 2018

LEQADA Mar 18, 2018

LEQADA Mar 18, 2018

JosephLeon Mar 18, 2018 •

edited

Loading

LEQADA Mar 18, 2018

Trott Mar 18, 2018

Trott Mar 18, 2018

JosephLeon Mar 18, 2018 •

edited

Loading

styfle Mar 20, 2018

benjamingr commented Mar 18, 2018

davisjam left a comment

Trott commented Mar 19, 2018

JosephLeon commented Mar 22, 2018

Trott commented Mar 22, 2018

Trott commented Mar 22, 2018

Trott commented Mar 22, 2018

JosephLeon commented Mar 22, 2018

Trott commented Mar 22, 2018


		If you didn't find an answer in one of the venues above, you can:

		* View unofficial [questions tagged 'node.js' on StackOverflow][]

doc: add text showing that stackoverflow is not managed or moderated … #19416

doc: add text showing that stackoverflow is not managed or moderated … #19416

Conversation

JosephLeon commented Mar 17, 2018

Checklist

Trott left a comment

Choose a reason for hiding this comment

Trott commented Mar 17, 2018

Trott commented Mar 17, 2018

JosephLeon commented Mar 18, 2018 • edited Loading

Trott left a comment

Choose a reason for hiding this comment

JosephLeon commented Mar 18, 2018

LEQADA Mar 18, 2018

Choose a reason for hiding this comment

LEQADA Mar 18, 2018

Choose a reason for hiding this comment

JosephLeon Mar 18, 2018 • edited Loading

Choose a reason for hiding this comment

LEQADA Mar 18, 2018

Choose a reason for hiding this comment

Trott Mar 18, 2018

Choose a reason for hiding this comment

Trott Mar 18, 2018

Choose a reason for hiding this comment

JosephLeon Mar 18, 2018 • edited Loading

Choose a reason for hiding this comment

styfle Mar 20, 2018

Choose a reason for hiding this comment

benjamingr commented Mar 18, 2018

davisjam left a comment

Choose a reason for hiding this comment

Trott commented Mar 19, 2018

JosephLeon commented Mar 22, 2018

Trott commented Mar 22, 2018

Trott commented Mar 22, 2018

Trott commented Mar 22, 2018

JosephLeon commented Mar 22, 2018

Trott commented Mar 22, 2018

JosephLeon commented Mar 18, 2018 •

edited

Loading

JosephLeon Mar 18, 2018 •

edited

Loading

JosephLeon Mar 18, 2018 •

edited

Loading