test: fix flaky test-http2-ping-flood #19395
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test is unreliable on some Windows platforms in its current form. Make it more robust by using `setInterval()` to repeat the flooding until an error is triggered.
|
CI: https://ci.nodejs.org/job/node-test-pull-request/13707/ If this works, this may be the first green CI in a loooooong time.... |
|
Three CI failures, all unrelated. Windows is green for the first time in probably weeks or more! Trying CI again: https://ci.nodejs.org/job/node-test-pull-request/13708/ |
addaleax
approved these changes
Mar 16, 2018
|
Ci is green. Like, not yellow. Green. Honest green. Let's land this, shall we? |
richardlau
reviewed
Mar 17, 2018
| message: | ||
| 'Flooding was detected in this HTTP/2 session, and it must be closed' | ||
| })); | ||
| session.on('error', (e) => { |
There was a problem hiding this comment.
Maybe keep common.expectsError and have a second session.on('error', ... for clearInterval?
Edit: not blocking (let's get that CI green), I just find common.expectsError clearer.
daynin
approved these changes
Mar 17, 2018
Trott
added
the
author ready
jasnell
approved these changes
Mar 17, 2018
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Mar 19, 2018
The test is unreliable on some Windows platforms in its current form. Make it more robust by using `setInterval()` to repeat the flooding until an error is triggered. PR-URL: nodejs#19395 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
|
Landed in 0fb017d |
MylesBorins
pushed a commit
that referenced
this pull request
Mar 20, 2018
The test is unreliable on some Windows platforms in its current form. Make it more robust by using `setInterval()` to repeat the flooding until an error is triggered. PR-URL: #19395 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 20, 2018
The test is unreliable on some Windows platforms in its current form. Make it more robust by using `setInterval()` to repeat the flooding until an error is triggered. PR-URL: #19395 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
tniessen
removed
the
author ready
BethGriggs
pushed a commit
that referenced
this pull request
Oct 26, 2018
The test is unreliable on some Windows platforms in its current form. Make it more robust by using `setInterval()` to repeat the flooding until an error is triggered. PR-URL: #19395 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test is unreliable on some Windows platforms in its current form.
Make it more robust by using
setInterval()to repeat the floodinguntil an error is triggered.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes