Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: improve text in async_hooks.md #19312

Closed
wants to merge 1 commit into from
Closed

Conversation

Trott
Copy link
Member

@Trott Trott commented Mar 13, 2018

  • Remove unnecessary Note: designations.
  • Various small edits for tone, punctuation, etc.
Checklist

* Remove unnecessary *Note:* designations.
* Various small edits for tone, punctuation, etc.
@nodejs-github-bot nodejs-github-bot added async_hooks Issues and PRs related to the async hooks subsystem. doc Issues and PRs related to the documentations. labels Mar 13, 2018
@Trott
Copy link
Member Author

Trott commented Mar 13, 2018

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 13, 2018
`0` means it's being executed from C++, with no JavaScript stack above it).
With only that information, it would be impossible to link resources together in
connection is made, the `TCPWrap` instance is immediately constructed. This
happens outside of any JavaScript stack. (An `executionAsyncId()` of `0` means
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The full sentence in parens followed by a period outside of the parens looks a little bit odd.

Trott added a commit to Trott/io.js that referenced this pull request Mar 15, 2018
* Remove unnecessary *Note:* designations.
* Various small edits for tone, punctuation, etc.

PR-URL: nodejs#19312
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@Trott
Copy link
Member Author

Trott commented Mar 15, 2018

Landed in 8d336dd

@Trott Trott closed this Mar 15, 2018
@refack refack mentioned this pull request Oct 18, 2018
3 tasks
@Trott Trott deleted the nonotes branch January 13, 2022 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
async_hooks Issues and PRs related to the async hooks subsystem. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants