Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: rename regression tests with descriptive file names (pt. 3) #19275

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,11 @@ const common = require('../common');
if (!common.hasCrypto)
common.skip('missing crypto');

// This test ensures that node doesn't SEGFAULT when either of
// `crypto.createHash` or `crypto.createHmac` are given an object that defines
// a throwing `toString`.
// https://github.com/nodejs/node/issues/9819

const assert = require('assert');
const execFile = require('child_process').execFile;

Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
'use strict';
require('../common');

// This test ensures that `addRequest`'s Legacy API accepts `localAddress`
// correctly instead of accepting `path`.
// https://github.com/nodejs/node/issues/5051

const assert = require('assert');
const agent = require('http').globalAgent;

Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
'use strict';
const common = require('../common');

// This test ensures that port numbers are validated in *all* kinds of `listen`
// calls. If an invalid port is supplied, ensures a `RangeError` is thrown.
// https://github.com/nodejs/node/issues/5727

const assert = require('assert');
const net = require('net');

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,10 @@

'use strict';
require('../common');

// This test ensures piping from `stdin` isn't broken.
// https://github.com/nodejs/node/issues/5927

const assert = require('assert');
const readline = require('readline');

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,4 +22,8 @@
'use strict';
require('../common');

// This test ensures v8 correctly sets a property on the global object if it
// has a setter interceptor in strict mode.
// https://github.com/nodejs/node-v0.x-archive/issues/6235

require('vm').runInNewContext('"use strict"; var v = 1; v = 2');