Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: rename regression tests with descriptive file names #19161

Closed
wants to merge 8 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -20,12 +20,13 @@
// USE OR OTHER DEALINGS IN THE SOFTWARE.

'use strict';
require('../common');

// Open a chain of five Node processes each a child of the next. The final
// process exits immediately. Each process in the chain is instructed to
// exit when its child exits.
// process exits immediately. Each process in the chain is instructed to exit
// when its child exits.
// https://github.com/joyent/node/issues/1726

require('../common');
const assert = require('assert');
const ch = require('child_process');

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,19 @@
'use strict';
require('../common');
const { fixturesDir } = require('../common/fixtures');

// Check that the calls to Integer::New() and Date::New() succeed and bail out
// if they don't.
// V8 returns an empty handle on stack overflow. Trying to set the empty handle
// as a property on an object results in a NULL pointer dereference in release
// builds and an assert in debug builds.
// https://github.com/nodejs/node-v0.x-archive/issues/4015

const assert = require('assert');
const { exec } = require('child_process');

const cmd =
`"${process.execPath}" "${fixturesDir}/test-regress-GH-4015.js"`;
`"${process.execPath}" "${fixturesDir}/test-fs-stat-sync-overflow.js"`;

exec(cmd, function(err, stdout, stderr) {
assert(/RangeError: Maximum call stack size exceeded/.test(stderr));
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,17 @@

'use strict';
const common = require('../common');

// Make sure the deletion event gets reported in the following scenario:
// 1. Watch a file.
// 2. The initial stat() goes okay.
// 3. Something deletes the watched file.
// 4. The second stat() fails with ENOENT.

// The second stat() translates into the first 'change' event but a logic error
// stopped it from getting emitted.
// https://github.com/nodejs/node-v0.x-archive/issues/4027

const assert = require('assert');
const path = require('path');
const fs = require('fs');
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,15 +20,15 @@
// USE OR OTHER DEALINGS IN THE SOFTWARE.

'use strict';
// Regression test for GH-784
// https://github.com/joyent/node/issues/784
//
const common = require('../common');

// The test works by making a total of 8 requests to the server. The first
// two are made with the server off - they should come back as ECONNREFUSED.
// The next two are made with server on - they should come back successful.
// The next two are made with the server off - and so on. Without the fix
// we were experiencing parse errors and instead of ECONNREFUSED.
const common = require('../common');
// we were experiencing parse errors instead of ECONNREFUSED.
// https://github.com/nodejs/node-v0.x-archive/issues/784

const http = require('http');
const assert = require('assert');

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,10 @@

'use strict';
const common = require('../common');

// Make sure http server doesn't wait for socket pool to establish connections
// https://github.com/nodejs/node-v0.x-archive/issues/877

const http = require('http');
const assert = require('assert');

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,11 @@

'use strict';
const common = require('../common');

// Make sure the net module's server doesn't throw an error when handling
// responses that are either too long or too small (especially on Windows)
// https://github.com/nodejs/node-v0.x-archive/issues/1697

const net = require('net');
const cp = require('child_process');

Expand Down