Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: enable ESLint quote-props rule #19156

Closed
wants to merge 2 commits into from
Closed

tools: enable ESLint quote-props rule #19156

wants to merge 2 commits into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Mar 5, 2018

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

tools

Trott added 2 commits March 5, 2018 15:51
@Trott
benchmark,lib,test,tools: use consistent quotes
a76e0be 
In preparation for a linting rule, use consistent quotation for
properties in objects.
@Trott
tools: enable ESLint quote-props rule
d86fa63 
Refs: nodejs#19100 (comment)
@Trott Trott added the tools Issues and PRs related to the tools directory. label Mar 5, 2018
@Trott
Copy link
Member Author

Trott commented Mar 5, 2018

@nodejs/linting

@Trott
Copy link
Member Author

Trott commented Mar 5, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/13520/

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 6, 2018
@vsemozhetbyt
Copy link
Contributor

Would consistent-as-needed be a bit more protective? It may not require any other changes in the PR but may protect against unneeded quotes in the future.

@Trott
Copy link
Member Author

Trott commented Mar 6, 2018 •
edited
Loading

Would consistent-as-needed be a bit more protective? It may not require any other changes in the PR but may protect against unneeded quotes in the future.

@vsemozhetbyt consistent-as-needed would require around 500 changes across more than 70 files. That was above my comfort level, especially since I'll be the one back-porting. :-D

We can consider moving to that in a subsequent PR, perhaps.

@vsemozhetbyt
Copy link
Contributor

Oops, sorry, did not suspect this. Sorry for not checking this by myself.

@BridgeAR BridgeAR added the fast-track PRs that do not need to wait for 48 hours to land. label Mar 6, 2018
Trott added a commit to Trott/io.js that referenced this pull request Mar 8, 2018
@Trott
benchmark,lib,test,tools: use consistent quotes
3c31bff 
In preparation for a linting rule, use consistent quotation for
properties in objects.

PR-URL: nodejs#19156
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Teddy Katz <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
Trott added a commit to Trott/io.js that referenced this pull request Mar 8, 2018
@Trott
tools: enable ESLint quote-props rule
ebfed17 
Refs: nodejs#19100 (comment)
PR-URL: nodejs#19156
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Teddy Katz <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
@Trott
Copy link
Member Author

Trott commented Mar 8, 2018

Landed in 3c31bff and ebfed17

@Trott Trott closed this Mar 8, 2018
targos pushed a commit that referenced this pull request Mar 17, 2018
@Trott @targos
benchmark,lib,test,tools: use consistent quotes
e85f703 
In preparation for a linting rule, use consistent quotation for
properties in objects.

PR-URL: #19156
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Teddy Katz <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
@targos targos mentioned this pull request Mar 18, 2018
Merged
@MylesBorins
Copy link
Contributor

This needs to be backported along with #18566

MylesBorins pushed a commit that referenced this pull request Mar 20, 2018
@Trott @MylesBorins
benchmark,lib,test,tools: use consistent quotes
563bed0 
In preparation for a linting rule, use consistent quotation for
properties in objects.

PR-URL: #19156
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Teddy Katz <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
@Trott
Copy link
Member Author

Trott commented Apr 25, 2018

@MylesBorins One of the two commits in this PR is already in v9.x-staging and the other one probably shouldn't go in. So I think this doesn't need a backport anymore, at least not to v9.x-staging. I'll remove the label, but leaving this comment in case I'm Doing It Wrong.

MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
@Trott @MayaLekova
benchmark,lib,test,tools: use consistent quotes
9d06b5b 
In preparation for a linting rule, use consistent quotation for
properties in objects.

PR-URL: nodejs#19156
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Teddy Katz <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
@Trott @MayaLekova
tools: enable ESLint quote-props rule
a07154f 
Refs: nodejs#19100 (comment)
PR-URL: nodejs#19156
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Teddy Katz <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
@Trott Trott deleted the quote-props branch January 13, 2022 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@not-an-aardvark not-an-aardvark not-an-aardvark approved these changes

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@devsnek devsnek devsnek approved these changes

@tniessen tniessen tniessen approved these changes

@cjihrig cjihrig cjihrig approved these changes

@targos targos targos approved these changes

@jasnell jasnell jasnell approved these changes

@silverwind silverwind silverwind approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.