net: fix usage of writeBuffer in makeSyncWrite #19103
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The binding writeBuffer has been changed in nodejs#19041 and it now requires the last argument to be a context object. makeSyncWrite was not updated accordingly, resulting assertions on Windows. This patch fixes the usage of writeBuffer there.
joyeecheung
added
the
fast-track
|
cc @addaleax Adding fast-track to unbreak Windows CI on master |
3 tasks
addaleax
approved these changes
Mar 3, 2018
joyeecheung
force-pushed
the
fix-win-write-buffer
branch
from
8d18e3b to
9620e7b
Compare
|
Updated to fix the enumerable New CI: https://ci.nodejs.org/job/node-test-pull-request/13466/ |
|
Only one known failure in Windows, fix is in #19093 I'll go ahead and land this to unbreak master. |
|
Landed in 67b5985, thanks! |
joyeecheung
added a commit
that referenced
this pull request
Mar 3, 2018
The binding writeBuffer has been changed in #19041 and it now requires the last argument to be a context object. makeSyncWrite was not updated accordingly, resulting assertions on Windows. This patch fixes the usage of writeBuffer there. Also fix errors.uvException() so error.message are no longer enumerable, this fixes the deepStrictEqual assertion on the error object in test-stdout-close-catch. PR-URL: #19103 Refs: #19041 Reviewed-By: Anna Henningsen <[email protected]>
4 tasks
MayaLekova
pushed a commit
to MayaLekova/node
that referenced
this pull request
May 8, 2018
The binding writeBuffer has been changed in nodejs#19041 and it now requires the last argument to be a context object. makeSyncWrite was not updated accordingly, resulting assertions on Windows. This patch fixes the usage of writeBuffer there. Also fix errors.uvException() so error.message are no longer enumerable, this fixes the deepStrictEqual assertion on the error object in test-stdout-close-catch. PR-URL: nodejs#19103 Refs: nodejs#19041 Reviewed-By: Anna Henningsen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The binding writeBuffer has been changed in
#19041 and it now requires
the last argument to be a context object. makeSyncWrite
was not updated accordingly, resulting assertions on Windows.
This patch fixes the usage of writeBuffer there.
Refs: #19041
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
net