Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

next: Update v8 to 4.3.61.27 #1909

Closed
wants to merge 2 commits into from
Closed

next: Update v8 to 4.3.61.27 #1909

wants to merge 2 commits into from

Conversation

targos
Copy link
Member

@targos targos commented Jun 6, 2015

targos and others added 2 commits June 6, 2015 08:59
@targos
deps: upgrade v8 to 4.3.61.27
2b67ca5
@indutny @targos
deps: backport 1f8555 from v8's upstream
9745eca 
Original commit message:

    api: introduce SealHandleScope

    When debugging Handle leaks in io.js we found it very convenient to be
    able to Seal some specific (root in our case) scope to prevent Handle
    allocations in it, and easily find leakage.

    R=yangguo
    BUG=

    Review URL: https://codereview.chromium.org/1079713002

    Cr-Commit-Position: refs/heads/master@{nodejs#27766}

Should help us identify and fix Handle leaks in core and user-space code.

NOTE: Works only in Debug build now, but is still better than nothing.

PR-URL: nodejs#1395
Reviewed-By: Ben Noordhuis <[email protected]>
@mscdex mscdex added the v8 engine Issues and PRs related to the V8 dependency. label Jun 6, 2015
@Fishrock123
Copy link
Contributor

cc @bnoordhuis

@trevnorris
Copy link
Contributor

Not near my laptop or would do it myself, but let's kick off a CI. Change looks pretty straight forward.

@cjihrig
Copy link
Contributor

cjihrig commented Jun 10, 2015

CI: https://jenkins-iojs.nodesource.com/view/iojs/job/iojs+any-pr+multi/794/

@targos
Copy link
Member Author

targos commented Jun 15, 2015

New URL: https://jenkins-iojs.nodesource.com/view/iojs/job/iojs+any-pr+multi_old/794/
Anything possibly related in the failing tests?

@trevnorris
Copy link
Contributor

@chrisdickinson Please always leave a reason for closing.

@trevnorris trevnorris reopened this Jun 17, 2015
@targos
Copy link
Member Author

targos commented Jun 19, 2015

I'll close it myself in favor of the upgrade to V8 4.4: #1807 (comment)

@targos targos closed this Jun 19, 2015
@chrisdickinson
Copy link
Contributor

Ah, this was likely automatically closed by GitHub when I recut next. Sorry I missed it.

On Jun 16, 2015, at 9:27 PM, Trevor Norris [email protected] wrote:

@chrisdickinson Please always leave a reason for closing.

—
Reply to this email directly or view it on GitHub.

@targos targos deleted the next-v8-27 branch July 17, 2015 21:01
@snyk-bot snyk-bot mentioned this pull request Aug 11, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@targos @Fishrock123 @trevnorris @cjihrig @chrisdickinson @mscdex @indutny