Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http: prevent aborted event when request is complete #18999

Closed
wants to merge 4 commits into from

Commits on Feb 17, 2018

  1. http: prevent aborted event when request is complete

    When socket is closed on a response for a request that is being piped to a stream
    there is a condition where aborted event will be fired to http client when socket is
    closing and the incomingMessage stream is still set to readable.
    
    We need a check for request being complete and to only raise the 'aborted' event
    on the http client if we have not yet completed reading the response from the server.
    
    Fixes: nodejs#18756
    billywhizz committed Feb 17, 2018
    Configuration menu
    Copy the full SHA
    78a7cbe View commit details
    Browse the repository at this point in the history
  2. http: prevent aborted event when request is complete

    Tests in progress to reproduce issue consistently.
    
    Fixes: nodejs#18756
    billywhizz committed Feb 17, 2018
    Configuration menu
    Copy the full SHA
    68850ef View commit details
    Browse the repository at this point in the history

Commits on Feb 18, 2018

  1. working

    billywhizz committed Feb 18, 2018
    Configuration menu
    Copy the full SHA
    cfc03aa View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2018

  1. Configuration menu
    Copy the full SHA
    24e5755 View commit details
    Browse the repository at this point in the history