test: fix test-child-process-stdout-flush-exit #1868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure all the stdout data is available before performing the assertions.
| assert(gotBye); | ||
| child.on('close', function() { | ||
| assert.equal(stdout.slice(0, 6), 'hello\n'); | ||
| assert.equal(stdout.slice(stdout.length - 8), 'goodbye\n'); | ||
| }); |
There was a problem hiding this comment.
Can you wrap the callback in a common.mustCall(...) while you're here? LGTM otherwise.
|
@bnoordhuis done. Thanks |
|
Cheers. Let's see what the CI thinks: https://jenkins-iojs.nodesource.com/view/iojs/job/iojs+any-pr+multi/751/ |
|
Probably related to #944 |
| }); | ||
| child.on('close', common.mustCall(function() { | ||
| assert.equal(stdout.slice(0, 6), 'hello\n'); | ||
| assert.equal(stdout.slice(stdout.length - 8), 'goodbye\n'); |
There was a problem hiding this comment.
assert.strictEqual would be better, no?
There was a problem hiding this comment.
Doesn't really matter for primitives. I'll land it, CI is happy.
|
Landed in 311c3e4, thanks. |
|
(LGTM) |
bnoordhuis
pushed a commit
that referenced
this pull request
Jun 2, 2015
Make sure all the stdout data is available before performing the assertions. Fixes: #944 PR-URL: #1868 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]>
|
Updated in b926718. |
andrewdeandrade
pushed a commit
to andrewdeandrade/node
that referenced
this pull request
Jun 3, 2015
Make sure all the stdout data is available before performing the assertions. Fixes: nodejs/node#944 PR-URL: nodejs/node#1868 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure all the stdout data is available before
performing the assertions.
Before this change, I was getting this error from time to time: