build: added doc linting when runnning make lint

[camilo86]

Fixes: #18466

Lint docs when running make lint. Added a call to lint-md inside the lint command in the Makefiile

Checklist

• commit message follows commit guidelines

Affected core subsystem(s)

build

[danbev]

@camilo86 Thanks for this! I think this PR should be opened against the master branch first though, and then it can be cherry-picked to the v9.5.0-proposal branch (unless I'm missing some context here and this should be handled differently, in that case just ignore me).

[joyeecheung]

@danbev @camilo86 Yes, please retarget this PR to the master branch. FWIW, this is how:

1. Fetch the latest master to your directory via something like git checkout master -> git fetch upstream master -> git reset --hard master (I am assuming upstream is the remote pointing to this repo)

2. Regenerate this patch from the master branch. Note that you can't rebase this branch onto master since v9.x is very different from master now. You can either

   1. Make another branch from master and cherry-pick this commit

   git checkout master
   git checkout -b new-pr-branch-name
   git cherry-pick b2e4d19
   git branch -D v9.5.0-proposal
   git branch -m v9.5.0-proposal
   

   (BTW v9.5.0-proposal is not a good PR branch name since there is a duplicate in the upstream...but you can still finish this PR with it. We usually use a name that describes the patch though)

   2. or reset your current PR branch to master then edit Makefile since it's just a one-line change.

   git checkout v9.5.0-proposal  # current PR branch
   git reset --hard master
   git cherry-pick b2e4d19  # or you can just edit the file but I think git would remember this sha if you have not prune the repo
   

3. Push the "Edit" button next to the PR title on this page, set the base branch to master

4. git push --force from your local edited PR branch to the remote PR branch.

[camilo86]

Thanks @danbev @joyeecheung . I changed the PR branch to master. Let me know if there is anything else that needs change.

[joyeecheung]

CI: https://ci.nodejs.org/job/node-test-pull-request/12870/

[BridgeAR]

I am not certain but I thought there was a reason it was not done anymore?

[joyeecheung]

@BridgeAR I guess it might be because we didn't want make lint fail when remark-cli was not there? But that should be fixed by #16893

[BridgeAR]

Makes sense. Thanks for the heads up.

[targos]

New CI: https://ci.nodejs.org/job/node-test-pull-request/12967/

[targos]

Landed in 0548034. Thanks!