Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix test/parallel/test-tls-server-verify.js on Windows CI #18382

Closed
wants to merge 1 commit into from
Closed

test: fix test/parallel/test-tls-server-verify.js on Windows CI #18382

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Jan 25, 2018 •
edited
Loading

The test runs two test cases at a time. This is not relevant to what the
test is actually testing. Not sure why doing it that way causes a
deadlock on some Windows servers, but running one at a time fixes it.

Fixes: #18269

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@Trott Trott added the wip Issues and PRs that are still a work in progress. label Jan 25, 2018
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jan 25, 2018
@Trott Trott force-pushed the fix-broken-windows-test branch from a2b91a2 to f80676d Compare January 25, 2018 22:52
@Trott
test: fix test/parallel/test-tls-server-verify.js on Windows CI
e3a4fd1 
The test runs two test cases at a time. This is not relevant to what the
test is actually testing. Not sure why doing it that way causes a
deadlock on some Windows servers, but running one at a time fixes it.

Fixes: nodejs#18269
@Trott Trott force-pushed the fix-broken-windows-test branch from 54c392f to e3a4fd1 Compare January 26, 2018 00:27
@Trott Trott changed the title wip: experiment to fix test-tls-server-verify.js test: fix test/parallel/test-tls-server-verify.js on Windows CI Jan 26, 2018
@Trott Trott mentioned this pull request Jan 26, 2018
Closed
@Trott
Copy link
Member Author

Trott commented Jan 26, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/12743/

@Trott Trott added fast-track PRs that do not need to wait for 48 hours to land. and removed wip Issues and PRs that are still a work in progress. labels Jan 26, 2018
@Trott
Copy link
Member Author

Trott commented Jan 26, 2018

No longer in progress. Ready to land, I hope. PTAL. @nodejs/testing

@Trott
Copy link
Member Author

Trott commented Jan 26, 2018

Sweet sweet passing test where it was failing before:

ok 411 parallel/test-tls-server-verify
  ---
  duration_ms: 10.681

Fast track anyone?

@joyeecheung
Copy link
Member

See #1461 and #1836

cc @nodejs/crypto

Should be safe to run them in parallel:

commit 975e5956f06692259a0584e1e31d81d011e20320
Author: João Reis <[email protected]>
Date:   Fri May 22 14:28:11 2015 +0100

    test: run tls-server-verify servers in parallel

    Different servers must use different ports. Since we can count only on
    common.PORT and common.PORT+1, run only 2 servers in parallel.

    Fixes: https://github.com/nodejs/io.js/issues/1461
    PR-URL: https://github.com/nodejs/io.js/pull/1836
    Reviewed-By: Ben Noordhuis <[email protected]>

@apapirovski
Copy link
Member

I'm happy this is getting fixed but it only started failing reasonably recently and seems like it could be hiding a legitimate bug. The thing is, the real issue in this test might not even be tls but with child_process given its extensive usage.

Maybe a TODO could be left to investigate why the test is failing on Windows when two parallel runTest are executed?

@Trott
Copy link
Member Author

Trott commented Jan 26, 2018

investigate why the test is failing on Windows when two parallel runTest are executed?

On it. Hoping to have a known_issues test to submit in a different PR.

@Trott
Copy link
Member Author

Trott commented Jan 26, 2018

Landed in 1ecd2be

@Trott Trott closed this Jan 26, 2018
Trott added a commit that referenced this pull request Jan 26, 2018
@Trott
test: fix test-tls-server-verify.js on Windows CI
1ecd2be 
The test runs two test cases at a time. This is not relevant to what the
test is actually testing. Not sure why doing it that way causes a
deadlock on some Windows servers, but running one at a time fixes it.

Fixes: #18269

PR-URL: #18382
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@evanlucas evanlucas mentioned this pull request Jan 30, 2018
Merged
evanlucas pushed a commit that referenced this pull request Jan 30, 2018
@Trott @evanlucas
test: fix test-tls-server-verify.js on Windows CI
1458e51 
The test runs two test cases at a time. This is not relevant to what the
test is actually testing. Not sure why doing it that way causes a
deadlock on some Windows servers, but running one at a time fixes it.

Fixes: #18269

PR-URL: #18382
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 5, 2018
@Trott @MylesBorins
test: fix test-tls-server-verify.js on Windows CI
75fbd51 
The test runs two test cases at a time. This is not relevant to what the
test is actually testing. Not sure why doing it that way causes a
deadlock on some Windows servers, but running one at a time fixes it.

Fixes: #18269

PR-URL: #18382
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Feb 7, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Feb 7, 2018
@Trott @MylesBorins
test: fix test-tls-server-verify.js on Windows CI
51999d0 
The test runs two test cases at a time. This is not relevant to what the
test is actually testing. Not sure why doing it that way causes a
deadlock on some Windows servers, but running one at a time fixes it.

Fixes: #18269

PR-URL: #18382
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 11, 2018
@Trott @MylesBorins
test: fix test-tls-server-verify.js on Windows CI
79016c5 
The test runs two test cases at a time. This is not relevant to what the
test is actually testing. Not sure why doing it that way causes a
deadlock on some Windows servers, but running one at a time fixes it.

Fixes: #18269

PR-URL: #18382
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 12, 2018
@Trott @MylesBorins
test: fix test-tls-server-verify.js on Windows CI
94c0acb 
The test runs two test cases at a time. This is not relevant to what the
test is actually testing. Not sure why doing it that way causes a
deadlock on some Windows servers, but running one at a time fixes it.

Fixes: #18269

PR-URL: #18382
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 13, 2018
@Trott @MylesBorins
test: fix test-tls-server-verify.js on Windows CI
fce10f7 
The test runs two test cases at a time. This is not relevant to what the
test is actually testing. Not sure why doing it that way causes a
deadlock on some Windows servers, but running one at a time fixes it.

Fixes: #18269

PR-URL: #18382
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
@Trott @MayaLekova
test: fix test-tls-server-verify.js on Windows CI
cc06f41 
The test runs two test cases at a time. This is not relevant to what the
test is actually testing. Not sure why doing it that way causes a
deadlock on some Windows servers, but running one at a time fixes it.

Fixes: nodejs#18269

PR-URL: nodejs#18382
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@Trott Trott deleted the fix-broken-windows-test branch January 13, 2022 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joyeecheung joyeecheung joyeecheung approved these changes

@cjihrig cjihrig cjihrig approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

investigate flaky parallel/test-tls-server-verify on Windows
6 participants
@Trott @joyeecheung @apapirovski @jasnell @cjihrig @nodejs-github-bot