build: fix building addons in debug mode #18301
Conversation
After cleaning addons, running `make build-addons` failed when Node was configured for debug mode, because the Makefile was expecting `build/Release/` addon paths, not `build/Debug/` addon paths.
nodejs-github-bot
added
the
build
| $(1)build/Debug/.buildstamp: $(1)build/Makefile $(2) $(ADDON_PREREQS) | ||
| $(NODE_GYP) --directory=$(1) --debug build | ||
| @touch $$@ | ||
| $(1)build/Debug/binding.node: $(1)build/Debug/.buildstamp |
There was a problem hiding this comment.
Could we reduce duplication by using $(BUILDTYPE)?
There was a problem hiding this comment.
Wouldn't make much difference because you still need the rule that passes --debug to node-gyp.
You could unify them if the call to node-gyp build was replaced with make -C $(1)/build but that's somewhat unofficial.
There was a problem hiding this comment.
$(NODE_GYP) --directory=$(1) --$(BUILDTYPE) build?
There was a problem hiding this comment.
Doesn't work; the argument is case-sensitive. I suppose you could use $(subst $(subst ...), ...) but that's arguably harder to read than ^.
|
This needs a rebase. Otherwise it seems like it could land @addaleax |
|
The original commits have been reverted. I'll reland them after the next libuv upgrade and include this PR. |
|
@bnoordhuis #18918 landed with the new libuv version. |
|
Ping @bnoordhuis |
|
Ping @bnoordhuis again |
|
Since this is based on code that does not exist anymore due to the revert and there is no timeframe for it to land again, I am going to close this. Please reopen if someone disagrees. |
After cleaning addons, running
make build-addonsfailedwhen Node was configured for debug mode,
because the Makefile was expecting
build/Release/addon paths,not
build/Debug/addon paths.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
build