-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stream: readable stream should not push undefined in non-objectMode #18244
stream: readable stream should not push undefined in non-objectMode #18244
Conversation
Why do we need it? I'm not understanding the reasoning behind this. |
Current Node.js allows we to push |
@MoonBall It would be helpful if you could explain why you think that that should not be allowed? |
There is no obvious reason. just feeling. |
@addaleax If we allow it, I can add a test case and a comment to explain the reason. |
ba704a3
to
a186f78
Compare
Thanks for the investigation! |
From the doc:
But current Node.js allows we to push
undefined
when stream is in non-object mode.Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passesAffected core subsystem(s)
stream