Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: remove orphaned entries from status #18092

Closed
wants to merge 1 commit into from
Closed

test: remove orphaned entries from status #18092

wants to merge 1 commit into from

Conversation

kfarnung
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@kfarnung kfarnung requested a review from Trott January 10, 2018 23:20
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jan 10, 2018
@kfarnung
Copy link
Contributor Author

CI: https://ci.nodejs.org/job/node-test-pull-request/12495/

@jasnell jasnell added the fast-track PRs that do not need to wait for 48 hours to land. label Jan 11, 2018
jasnell pushed a commit that referenced this pull request Jan 11, 2018
@kfarnung @jasnell
test: remove orphaned entries from status
7c84f19 
PR-URL: #18092
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
@jasnell
Copy link
Member

jasnell commented Jan 11, 2018

Landed in 7c84f19

@jasnell jasnell closed this Jan 11, 2018
evanlucas pushed a commit that referenced this pull request Jan 30, 2018
@kfarnung @evanlucas
test: remove orphaned entries from status
7706e5f 
PR-URL: #18092
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
@evanlucas evanlucas mentioned this pull request Jan 30, 2018
Merged
@MylesBorins
Copy link
Contributor

This should likely be done for both v6.x and v8.x as well

@kfarnung
Copy link
Contributor Author

@MylesBorins I just pushed #19042 and #19043 for those branches.

@kfarnung kfarnung deleted the orphanstatus branch February 27, 2018 19:04
BethGriggs pushed a commit that referenced this pull request Apr 10, 2018
@kfarnung @BethGriggs
test: remove orphaned entries from status
745600a 
PR-URL: #18092
Backport-PR-URL: #19043
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
@MylesBorins MylesBorins mentioned this pull request May 2, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@cjihrig cjihrig cjihrig approved these changes

@Trott Trott Trott approved these changes

@jasnell jasnell jasnell approved these changes

@danbev danbev danbev approved these changes

Assignees
No one assigned
Labels
fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@kfarnung @jasnell @MylesBorins @danbev @Trott @cjihrig @gireeshpunathil @nodejs-github-bot