Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix incorrect argument type in fs.readSync #18022

Closed
wants to merge 1 commit into from
Closed

doc: fix incorrect argument type in fs.readSync #18022

wants to merge 1 commit into from

Conversation

belochub
Copy link
Contributor

@belochub belochub commented Jan 7, 2018

The buffer argument must be either Buffer or Uint8Array, string
values are not supported.

Checklist
Affected core subsystem(s)

doc

@belochub
doc: fix incorrect argument type in fs.readSync
6b33e56 
The `buffer` argument must be either Buffer or Uint8Array, string
values are not supported.
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system. labels Jan 7, 2018
jasnell pushed a commit that referenced this pull request Jan 9, 2018
@belochub @jasnell
doc: fix incorrect argument type in fs.readSync
bcb01de 
The `buffer` argument must be either Buffer or Uint8Array, string
values are not supported.

PR-URL: #18022
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Weijia Wang <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@jasnell
Copy link
Member

jasnell commented Jan 9, 2018

Landed in bcb01de

@jasnell jasnell closed this Jan 9, 2018
MylesBorins pushed a commit that referenced this pull request Jan 10, 2018
@belochub @MylesBorins
doc: fix incorrect argument type in fs.readSync
d3544fd 
The `buffer` argument must be either Buffer or Uint8Array, string
values are not supported.

PR-URL: #18022
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Weijia Wang <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Jan 10, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Jan 10, 2018
@belochub @MylesBorins
doc: fix incorrect argument type in fs.readSync
ffc2659 
The `buffer` argument must be either Buffer or Uint8Array, string
values are not supported.

PR-URL: #18022
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Weijia Wang <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jan 24, 2018
@belochub @MylesBorins
doc: fix incorrect argument type in fs.readSync
b3ff0ed 
The `buffer` argument must be either Buffer or Uint8Array, string
values are not supported.

PR-URL: #18022
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Weijia Wang <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@starkwang starkwang starkwang approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@tniessen tniessen tniessen approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@belochub @jasnell @lpinca @cjihrig @tniessen @gireeshpunathil @starkwang @MylesBorins @nodejs-github-bot