Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: replace assert.throws with expectsError #17997

Closed
wants to merge 1 commit into from
Closed

test: replace assert.throws with expectsError #17997

wants to merge 1 commit into from

Conversation

sreepurnajasti
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jan 5, 2018
@BridgeAR BridgeAR added fast-track PRs that do not need to wait for 48 hours to land. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Jan 5, 2018
@BridgeAR
Copy link
Member

BridgeAR commented Jan 5, 2018

CI https://ci.nodejs.org/job/node-test-pull-request/12422/

jasnell pushed a commit that referenced this pull request Jan 9, 2018
@sreepurnajasti @jasnell
test: replace assert.throws with expectsError
7969811 
PR-URL: #17997
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@jasnell
Copy link
Member

jasnell commented Jan 9, 2018

Landed in 7969811

@jasnell jasnell closed this Jan 9, 2018
@MylesBorins
Copy link
Contributor

This change does not work on v9.x, could someone please backport

@sreepurnajasti sreepurnajasti deleted the expect-error branch January 10, 2018 04:51
@TimothyGu TimothyGu removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 13, 2018
@addaleax
Copy link
Member

@MylesBorins This seems to work now, I’m removing the backport-requested-v9.x label. I don’t suppose you remember how this failed? If it’s not a merge conflict, it might be helpful to have the errors you are seeing posted for context.

addaleax pushed a commit to addaleax/node that referenced this pull request Feb 27, 2018
@sreepurnajasti @addaleax
test: replace assert.throws with expectsError
1be5e33 
PR-URL: nodejs#17997
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@addaleax addaleax mentioned this pull request Feb 27, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@sreepurnajasti @BridgeAR @jasnell @MylesBorins @addaleax @lpinca @TimothyGu @nodejs-github-bot