Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http2: verify that a dependency cycle may exist #17968

Closed
wants to merge 1 commit into from

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Jan 3, 2018

Simple test to verify that a priority dependency cycle may exist but won't crash anything.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

http2

@jasnell jasnell added http2 Issues or PRs related to the http2 subsystem. test Issues and PRs related to the tests. labels Jan 3, 2018
@jasnell
Copy link
Member Author

jasnell commented Jan 5, 2018

jasnell added a commit that referenced this pull request Jan 5, 2018
@jasnell
Copy link
Member Author

jasnell commented Jan 5, 2018

Landed in 22760f3

@jasnell jasnell closed this Jan 5, 2018
MylesBorins pushed a commit that referenced this pull request Jan 8, 2018
MylesBorins pushed a commit that referenced this pull request Jan 9, 2018
MylesBorins pushed a commit to jasnell/node that referenced this pull request Jan 9, 2018
MylesBorins pushed a commit that referenced this pull request Jan 9, 2018
Backport-PR-URL: #18050
PR-URL: #17968
Reviewed-By: Anna Henningsen <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Jan 10, 2018
MylesBorins pushed a commit that referenced this pull request Jan 10, 2018
Backport-PR-URL: #18050
PR-URL: #17968
Reviewed-By: Anna Henningsen <[email protected]>
@MylesBorins
Copy link
Contributor

This lands cleanly on v8.x but the test fails. Likely blocked by another backport

=== release test-http2-priority-cycle- ===
Path: parallel/test-http2-priority-cycle-
(node:86045) ExperimentalWarning: The http2 module is an experimental API.
/Users/mborins/code/node/v8.x/test/parallel/test-http2-priority-cycle-.js:45
    client.close();
           ^

TypeError: client.close is not a function
    at Countdown (/Users/mborins/code/node/v8.x/test/parallel/test-http2-priority-cycle-.js:45:12)
    at Countdown.dec (/Users/mborins/code/node/v8.x/test/common/countdown.js:19:22)
    at ClientHttp2Stream.req.on (/Users/mborins/code/node/v8.x/test/parallel/test-http2-priority-cycle-.js:67:37)
    at emitOne (events.js:116:13)
    at ClientHttp2Stream.emit (events.js:211:7)
    at emit (internal/http2/core.js:144:8)
    at _combinedTickCallback (internal/process/next_tick.js:141:11)
    at process._tickCallback (internal/process/next_tick.js:180:9)

kjin pushed a commit to kjin/node that referenced this pull request May 1, 2018
MylesBorins pushed a commit that referenced this pull request May 2, 2018
Backport-PR-URL: #18050
Backport-PR-URL: #20456
PR-URL: #17968
Reviewed-By: Anna Henningsen <[email protected]>
@MylesBorins MylesBorins mentioned this pull request May 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
http2 Issues or PRs related to the http2 subsystem. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants