http2: properly handle already closed stream error #17942
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
|
Ping @nodejs/http2 |
mcollina
approved these changes
Jan 2, 2018
| array[pos] = val; | ||
| } | ||
|
|
||
| class Frame { |
There was a problem hiding this comment.
can you add some comments on how to use these?
jasnell
force-pushed
the
http2-closed-stream
branch
from
6ac0bfd
to
f714aac
Compare
|
CI is good |
jasnell
added a commit
that referenced
this pull request
Jan 3, 2018
PR-URL: #17942 Reviewed-By: Matteo Collina <[email protected]>
jasnell
added a commit
that referenced
this pull request
Jan 3, 2018
PR-URL: #17942 Reviewed-By: Matteo Collina <[email protected]>
MylesBorins
pushed a commit
to jasnell/node
that referenced
this pull request
Jan 9, 2018
PR-URL: nodejs#17942 Reviewed-By: Matteo Collina <[email protected]>
MylesBorins
pushed a commit
to jasnell/node
that referenced
this pull request
Jan 9, 2018
PR-URL: nodejs#17942 Reviewed-By: Matteo Collina <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 9, 2018
Backport-PR-URL: #18050 PR-URL: #17942 Reviewed-By: Matteo Collina <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 9, 2018
Backport-PR-URL: #18050 PR-URL: #17942 Reviewed-By: Matteo Collina <[email protected]>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Jan 10, 2018
Backport-PR-URL: #18050 PR-URL: #17942 Reviewed-By: Matteo Collina <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 10, 2018
Backport-PR-URL: #18050 PR-URL: #17942 Reviewed-By: Matteo Collina <[email protected]>
3 tasks
kjin
pushed a commit
to kjin/node
that referenced
this pull request
May 1, 2018
Backport-PR-URL: nodejs#18050 PR-URL: nodejs#17942 Reviewed-By: Matteo Collina <[email protected]>
kjin
pushed a commit
to kjin/node
that referenced
this pull request
May 1, 2018
Backport-PR-URL: nodejs#18050 PR-URL: nodejs#17942 Reviewed-By: Matteo Collina <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
May 2, 2018
Backport-PR-URL: #18050 Backport-PR-URL: #20456 PR-URL: #17942 Reviewed-By: Matteo Collina <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
May 2, 2018
Backport-PR-URL: #18050 Backport-PR-URL: #20456 PR-URL: #17942 Reviewed-By: Matteo Collina <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HTTP/2 RFC requires connection to be torn down if the client attempts to use an already closed stream ID.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
http2