http2: perf_hooks integration #17906

jasnell · 2017-12-28T22:07:25Z

Collect and report basic timing information about Http2Session and Http2Stream instances.

This is just the initial impl. Additional stats to be added.

const { PerformanceObserver } = require('perf_hooks');

const obs = new PerformanceObserver((items) => {
  const entry = items.getEntries()[0];
  console.log(entry);
});
obs.observe({ entryTypes: ['http2'] });

ping @nodejs/http2

Refs: #17746

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

Affected core subsystem(s)

http2

Collect and report basic timing information about `Http2Session` and `Http2Stream` instances.

vsemozhetbyt · 2017-12-28T22:11:27Z

doc/api/http2.md

@@ -2800,13 +2800,63 @@ given newly created [`Http2Stream`] on `Http2ServerRespose`.
 The callback will be called with an error with code `ERR_HTTP2_STREAM_CLOSED`
 if the stream is closed.

+## Collecting HTTP/2 Performance Metrics
+
+The [Performance Observer][] API can be used to collect basic performance


Should this be [Performance Hooks][] or should the bottom reference be changed?

reference updated

vsemozhetbyt · 2017-12-28T22:17:33Z

doc/api/http2.md

+If `name` is equal to `Http2Session`, the `PerformanceEntry` will contain the
+following additional properties:
+
+* `pingRTT` {number} The number of millseconds elapsed since the transmission


millseconds -> milliseconds

vsemozhetbyt · 2017-12-28T22:19:26Z

doc/api/http2.md

+following additional properties:
+
+* `pingRTT` {number} The number of millseconds elapsed since the transmission
+  of a `PING` frame and the reception of it's acknowledgement. Only present if


it's -> its

jasnell · 2017-12-28T23:34:57Z

CI: https://ci.nodejs.org/job/node-test-pull-request/12337/

jasnell · 2017-12-29T05:13:48Z

CI is good. One build bot failure on windows is unrelated.

jasnell · 2017-12-30T18:00:52Z

Ping @nodejs/http2

mcollina · 2018-01-02T10:34:47Z

doc/api/http2.md

+* `timeToFirstByte` {number} The number of milliseconds elapsed between the
+  `PerformanceEntry` `startTime` and the reception of the first `DATA` frame.
+* `timeToFirstHeader` {number} The number of milliseconds elapsed between the
+  `PerformanceEntry` `startTime` and the reception of the first header.


this is only for data coming in, should we include also some metrics for data going out?

Yep, this is only the initial implementation. Once it lands, I plan to extend the available metrics to include additional pieces.

mcollina

LGTM

Collect and report basic timing information about `Http2Session` and `Http2Stream` instances. PR-URL: #17906 Refs: #17746 Reviewed-By: Matteo Collina <[email protected]>

jasnell · 2018-01-02T16:58:19Z

Landed in 231b116

Collect and report basic timing information about `Http2Session` and `Http2Stream` instances. PR-URL: nodejs#17906 Refs: nodejs#17746 Reviewed-By: Matteo Collina <[email protected]>

Collect and report basic timing information about `Http2Session` and `Http2Stream` instances. Backport-PR-URL: #18050 PR-URL: #17906 Refs: #17746 Reviewed-By: Matteo Collina <[email protected]>

Notable change: * async_hooks: - deprecate AsyncHooks Sensitive API and runInAsyncIdScope. Neither API were documented. (Andreas Madsen) #16972 * deps: - update nghttp2 to 1.29.0 (James M Snell) #17908 - upgrade npm to 5.6.0 (Kat Marchán) #17535 - cherry-pick 50f7455 from upstream V8 (Michaël Zasso) #16591 * events: - remove reaches into _events internals (Anatoli Papirovski) #17440 * http: - add rawPacket in err of `clientError` event (XadillaX) #17672 * http2: - implement maxSessionMemory (James M Snell) #17967 - add initial support for originSet (James M Snell) #17935 - add altsvc support (James M Snell) #17917 - perf_hooks integration (James M Snell) #17906 * net: - remove Socket.prototype.write (Anna Henningsen) #17644 - remove Socket.prototype.listen (Ruben Bridgewater) #13735 * repl: - show lexically scoped vars in tab completion (Michaël Zasso) #16591 * stream: - rm {writeable/readable}State.length (Calvin Metcalf) #12857 - add flow and buffer properties to streams (Calvin Metcalf) #12855 * util: - allow wildcards in NODE_DEBUG variable (Tyler) #17609 * zlib: - add ArrayBuffer support (Jem Bezooyen) #16042 * Addedew collaborator** - [starkwang](https://github.com/starkwang) Weijia Wang * Addedew TSC member** - [danbev](https://github.com/danbev) Daniel Bevenius PR-URL: #18069

Collect and report basic timing information about `Http2Session` and `Http2Stream` instances. Backport-PR-URL: #18050 PR-URL: #17906 Refs: #17746 Reviewed-By: Matteo Collina <[email protected]>

Notable change: * async_hooks: - deprecate AsyncHooks Sensitive API and runInAsyncIdScope. Neither API were documented. (Andreas Madsen) #16972 * deps: - update nghttp2 to 1.29.0 (James M Snell) #17908 - upgrade npm to 5.6.0 (Kat Marchán) #17535 - cherry-pick 50f7455 from upstream V8 (Michaël Zasso) #16591 * events: - remove reaches into _events internals (Anatoli Papirovski) #17440 * http: - add rawPacket in err of `clientError` event (XadillaX) #17672 * http2: - implement maxSessionMemory (James M Snell) #17967 - add initial support for originSet (James M Snell) #17935 - add altsvc support (James M Snell) #17917 - perf_hooks integration (James M Snell) #17906 - Refactoring and cleanup of Http2Session and Http2Stream destroy (James M Snell) #17406 * net: - remove Socket.prototype.write (Anna Henningsen) #17644 - remove Socket.prototype.listen (Ruben Bridgewater) #13735 * repl: - show lexically scoped vars in tab completion (Michaël Zasso) #16591 * stream: - rm {writeable/readable}State.length (Calvin Metcalf) #12857 - add flow and buffer properties to streams (Calvin Metcalf) #12855 * util: - allow wildcards in NODE_DEBUG variable (Tyler) #17609 * zlib: - add ArrayBuffer support (Jem Bezooyen) #16042 * Addedew collaborator** - [starkwang](https://github.com/starkwang) Weijia Wang * Addedew TSC member** - [danbev](https://github.com/danbev) Daniel Bevenius PR-URL: #18069

Collect and report basic timing information about `Http2Session` and `Http2Stream` instances. Backport-PR-URL: nodejs#18050 PR-URL: nodejs#17906 Refs: nodejs#17746 Reviewed-By: Matteo Collina <[email protected]>

Collect and report basic timing information about `Http2Session` and `Http2Stream` instances. Backport-PR-URL: #18050 Backport-PR-URL: #20456 PR-URL: #17906 Refs: #17746 Reviewed-By: Matteo Collina <[email protected]>

http2: perf_hooks integration

40a2d6b

Collect and report basic timing information about `Http2Session` and `Http2Stream` instances.

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. labels Dec 28, 2017

vsemozhetbyt reviewed Dec 28, 2017

View reviewed changes

[Squash] nits

48b6374

jasnell mentioned this pull request Dec 28, 2017

[Tracking Issue]: Some http2 todos #17746

Closed

11 tasks

jasnell added the http2 Issues or PRs related to the http2 subsystem. label Jan 2, 2018

mcollina reviewed Jan 2, 2018

View reviewed changes

mcollina approved these changes Jan 2, 2018

View reviewed changes

jasnell added the dont-land-on-v8.x label Jan 2, 2018

jasnell added a commit that referenced this pull request Jan 2, 2018

http2: perf_hooks integration

231b116

Collect and report basic timing information about `Http2Session` and `Http2Stream` instances. PR-URL: #17906 Refs: #17746 Reviewed-By: Matteo Collina <[email protected]>

jasnell closed this Jan 2, 2018

MylesBorins mentioned this pull request Jan 10, 2018

v9.4.0 proposal #18069

Merged

MylesBorins added the dont-land-on-v6.x label Jan 19, 2018

MylesBorins mentioned this pull request May 2, 2018

v8.11.2 proposal #20478

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

http2: perf_hooks integration #17906

http2: perf_hooks integration #17906

jasnell commented Dec 28, 2017

vsemozhetbyt Dec 28, 2017

jasnell Dec 28, 2017

vsemozhetbyt Dec 28, 2017

vsemozhetbyt Dec 28, 2017

jasnell commented Dec 28, 2017

jasnell commented Dec 29, 2017

jasnell commented Dec 30, 2017

mcollina Jan 2, 2018

jasnell Jan 2, 2018

mcollina left a comment

jasnell commented Jan 2, 2018

http2: perf_hooks integration #17906

http2: perf_hooks integration #17906

Conversation

jasnell commented Dec 28, 2017

Checklist

Affected core subsystem(s)

vsemozhetbyt Dec 28, 2017

Choose a reason for hiding this comment

jasnell Dec 28, 2017

Choose a reason for hiding this comment

vsemozhetbyt Dec 28, 2017

Choose a reason for hiding this comment

vsemozhetbyt Dec 28, 2017

Choose a reason for hiding this comment

jasnell commented Dec 28, 2017

jasnell commented Dec 29, 2017

jasnell commented Dec 30, 2017

mcollina Jan 2, 2018

Choose a reason for hiding this comment

jasnell Jan 2, 2018

Choose a reason for hiding this comment

mcollina left a comment

Choose a reason for hiding this comment

jasnell commented Jan 2, 2018