http2: convert Http2Settings to an AsyncWrap #17763
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
lib / src
11 tasks
|
ping @mcollina @nodejs/http2 |
jasnell
force-pushed
the
http2-settings-async-req
branch
from
6596369
to
2ca60ac
Compare
mcollina
reviewed
Dec 21, 2017
lib/internal/http2/core.js
Outdated
| cb(err, this.localSettings, duration); | ||
| } | ||
| if (ack) | ||
| this.emit('localSettings', this.localSettings); |
There was a problem hiding this comment.
I would at least so a debug if ack is null.
There was a problem hiding this comment.
Just reworked the entire function a bit to clean it up more and add the debug output.
jasnell
force-pushed
the
http2-settings-async-req
branch
from
2f4808b
to
880bbee
Compare
jasnell
force-pushed
the
http2-settings-async-req
branch
from
bc4a14a
to
788c847
Compare
|
CI is good |
jasnell
added a commit
that referenced
this pull request
Dec 22, 2017
PR-URL: #17763 Refs: #17746 Reviewed-By: Matteo Collina <[email protected]>
|
Landed in bbaea12 |
MylesBorins
pushed a commit
to jasnell/node
that referenced
this pull request
Jan 9, 2018
PR-URL: nodejs#17763 Refs: nodejs#17746 Reviewed-By: Matteo Collina <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 9, 2018
Backport-PR-URL: #18050 PR-URL: #17763 Refs: #17746 Reviewed-By: Matteo Collina <[email protected]>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Jan 10, 2018
Backport-PR-URL: #18050 PR-URL: #17763 Refs: #17746 Reviewed-By: Matteo Collina <[email protected]>
kjin
pushed a commit
to kjin/node
that referenced
this pull request
May 1, 2018
Backport-PR-URL: nodejs#18050 PR-URL: nodejs#17763 Refs: nodejs#17746 Reviewed-By: Matteo Collina <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
May 2, 2018
Backport-PR-URL: #18050 Backport-PR-URL: #20456 PR-URL: #17763 Refs: #17746 Reviewed-By: Matteo Collina <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
Http2SettingsanAsyncWrap.Refs: #17746
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
http2