Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vm: fix a variety of bugs, using V8 4.3 APIs #1773

Closed
wants to merge 3 commits into from
Closed

vm: fix a variety of bugs, using V8 4.3 APIs #1773

wants to merge 3 commits into from

Commits on Jun 1, 2015

  1. vm: fix property descriptors of sandbox properties 

    The GlobalPropertyQueryCallback was changed in 2010 to return an
integer instead of a boolean:

https://groups.google.com/forum/#!topic/v8-users/OOjHJrix-cU

This integer communicates the property descriptors of the property,
instead of just its presence or absence. However, the original
contextify code was probably written before this change, and it was
not updated when porting to Node.js.

Credit to @smikes for the test and the original PR of nodejs#885.

Fixes nodejs#885; fixes nodejs#864.
    @domenic
    domenic committed Jun 1, 2015
    Configuration menu
    Copy the full SHA
    99104df View commit details
    Browse the repository at this point in the history

  2. vm: remove unnecessary access checks 

    No reason to install access checks if they're always going to return
true.
    @domenic
    domenic committed Jun 1, 2015
    Configuration menu
    Copy the full SHA
    6443054 View commit details
    Browse the repository at this point in the history

  3. vm: fix symbol access 

    By using the new SetHandler API instead of SetNamedPropertyHandler, we can
intercept symbols now. This forces us to use Maybes and MaybeLocals more,
since this new API does not have a non-maybe variant.

Fixes nodejs#884.
    @domenic
    domenic committed Jun 1, 2015
    Configuration menu
    Copy the full SHA
    5f69cda View commit details
    Browse the repository at this point in the history