Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tls: emit errors happening before handshake's finish #1769

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/_tls_wrap.js
Original file line number Diff line number Diff line change
Expand Up @@ -359,7 +359,6 @@ TLSSocket.prototype._init = function(socket, wrap) {
ssl.onerror = function(err) {
if (self._writableState.errorEmitted)
return;
self._writableState.errorEmitted = true;

// Destroy socket if error happened before handshake's finish
if (!self._secureEstablished) {
Expand All @@ -373,6 +372,8 @@ TLSSocket.prototype._init = function(socket, wrap) {
// Throw error
self._emitTLSError(err);
}

self._writableState.errorEmitted = true;
};

// If custom SNICallback was given, or if
Expand Down
46 changes: 46 additions & 0 deletions test/parallel/test-tls-handshake-error.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,46 @@
'use strict';

var assert = require('assert');
var common = require('../common');

if (!common.hasCrypto) {
console.log('1..0 # Skipped: missing crypto');
process.exit();
}
var tls = require('tls');

var fs = require('fs');
var net = require('net');

var errorCount = 0;
var closeCount = 0;

var server = tls.createServer({
key: fs.readFileSync(common.fixturesDir + '/keys/agent1-key.pem'),
cert: fs.readFileSync(common.fixturesDir + '/keys/agent1-cert.pem'),
rejectUnauthorized: true
}, function(c) {
}).listen(common.PORT, function() {
var c = tls.connect({
port: common.PORT,
ciphers: 'RC4'
}, function() {
assert(false, 'should not be called');
});

c.on('error', function(err) {
errorCount++;
assert.notEqual(err.code, 'ECONNRESET');
});

c.on('close', function(err) {
if (err)
closeCount++;
server.close();
});
});

process.on('exit', function() {
assert.equal(errorCount, 1);
assert.equal(closeCount, 1);
});