Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: remove unused function #17671

Closed
wants to merge 1 commit into from
Closed

src: remove unused function #17671

wants to merge 1 commit into from

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Dec 14, 2017

The function IsInt64() in src/node_file.cc is no longer used. This commit removes it.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

src

@cjihrig
src: remove unused function
4d3ad41 
The function IsInt64() in src/node_file.cc is no longer used.
This commit removes it.
Trott
Trott approved these changes Dec 14, 2017
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI is OK.

maclover7
maclover7 approved these changes Dec 14, 2017
View reviewed changes
Copy link
Contributor

@maclover7 maclover7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI is OK

@maclover7
Copy link
Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/12099/

@jasnell jasnell added fs Issues and PRs related to the fs subsystem / file system. lib / src Issues and PRs related to general changes in the lib or src directory. labels Dec 14, 2017
@cjihrig
Copy link
Contributor Author

cjihrig commented Dec 15, 2017

New CI: https://ci.nodejs.org/job/node-test-pull-request/12129/

@maclover7 maclover7 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 15, 2017
@BridgeAR BridgeAR added the fast-track PRs that do not need to wait for 48 hours to land. label Dec 15, 2017
@BridgeAR
Copy link
Member

Landed in c8ac188

@BridgeAR BridgeAR closed this Dec 15, 2017
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Dec 15, 2017
@cjihrig @BridgeAR
src: remove unused function
c8ac188 
The function IsInt64() in src/node_file.cc is no longer used.
This commit removes it.

PR-URL: nodejs#17671
Reviewed-By: Timothy Gu <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
@cjihrig cjihrig deleted the warning branch December 15, 2017 21:40
@addaleax addaleax removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 29, 2017
MylesBorins pushed a commit that referenced this pull request Jan 8, 2018
@cjihrig @MylesBorins
src: remove unused function
d5cef71 
The function IsInt64() in src/node_file.cc is no longer used.
This commit removes it.

PR-URL: #17671
Reviewed-By: Timothy Gu <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
@MylesBorins
Copy link
Contributor

This shouldn't have landed on 9.x, adding appropriate labels

@prenaut41 prenaut41 mentioned this pull request May 24, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@tniessen tniessen tniessen approved these changes

@maclover7 maclover7 maclover7 approved these changes

@TimothyGu TimothyGu TimothyGu approved these changes

@addaleax addaleax addaleax approved these changes

@Trott Trott Trott approved these changes

@evanlucas evanlucas evanlucas approved these changes

@jasnell jasnell jasnell approved these changes

@danbev danbev danbev approved these changes

Assignees
No one assigned
Labels
fast-track PRs that do not need to wait for 48 hours to land. fs Issues and PRs related to the fs subsystem / file system. lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.