Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src,stream: use SetAccessorProperty instead of SetAccessor #17665

Closed
wants to merge 16 commits into from
Closed

src,stream: use SetAccessorProperty instead of SetAccessor #17665

wants to merge 16 commits into from

Commits on Dec 13, 2017

  1. Change to using SetAccessorProperty instead of SetAccessor in StreamBase 

    Fixes: nodejs#17636
Refs: nodejs#16482
Refs: nodejs#16860
    @jure
    jure committed Dec 13, 2017
    Configuration menu
    Copy the full SHA
    329e162 View commit details
    Browse the repository at this point in the history

  2. Remove extra parentheses

    @jure
    jure committed Dec 13, 2017
    Configuration menu
    Copy the full SHA
    dcca3a5 View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2017

  1. Fix indentation

    @jure
    jure committed Dec 14, 2017
    Configuration menu
    Copy the full SHA
    ebbe147 View commit details
    Browse the repository at this point in the history

  2. Check for TypeError instead of matching error msg

    @jure
    jure committed Dec 14, 2017
    Configuration menu
    Copy the full SHA
    a03028f View commit details
    Browse the repository at this point in the history

  3. Change PrototypeTemplate SetAccessor to SetAccessorProperty

    @jure
    jure committed Dec 14, 2017
    Configuration menu
    Copy the full SHA
    06d8157 View commit details
    Browse the repository at this point in the history

  4. Changing SetAccessor to SetAccessorProperty in udp_wrap

    @jure
    jure committed Dec 14, 2017
    Configuration menu
    Copy the full SHA
    0b96b12 View commit details
    Browse the repository at this point in the history

  5. Change InstanceTemplate SetAccessor to SetAccessorProperty

    @jure
    jure committed Dec 14, 2017
    Configuration menu
    Copy the full SHA
    26ffff1 View commit details
    Browse the repository at this point in the history

  6. Change InstanceTemplate SetAccessor to SetAccessorProperty

    @jure
    jure committed Dec 14, 2017
    Configuration menu
    Copy the full SHA
    9292fa0 View commit details
    Browse the repository at this point in the history

  7. Fix indentation and linting errors in node_crypto

    @jure
    jure committed Dec 14, 2017
    Configuration menu
    Copy the full SHA
    354008a View commit details
    Browse the repository at this point in the history

  8. Fixes for indentation

    @jure
    jure committed Dec 14, 2017
    Configuration menu
    Copy the full SHA
    a199e07 View commit details
    Browse the repository at this point in the history

  9. Add more tests for UDP and crypto

    @jure
    jure committed Dec 14, 2017
    Configuration menu
    Copy the full SHA
    5eb6507 View commit details
    Browse the repository at this point in the history

  10. Fixes for indentation

    @jure
    jure committed Dec 14, 2017
    Configuration menu
    Copy the full SHA
    232d2be View commit details
    Browse the repository at this point in the history

  11. Use env->as_external to get access to Environment in callback

    @jure
    jure committed Dec 14, 2017
    Configuration menu
    Copy the full SHA
    d89578a View commit details
    Browse the repository at this point in the history

  12. More env->as_external to get access to Environment in callback

    @jure
    jure committed Dec 14, 2017
    Configuration menu
    Copy the full SHA
    5a60daa View commit details
    Browse the repository at this point in the history

  13. Use env->as_external in node_perf too

    @jure
    jure committed Dec 14, 2017
    Configuration menu
    Copy the full SHA
    84905d6 View commit details
    Browse the repository at this point in the history

  14. Update comments

    @jure
    jure authored Dec 14, 2017
    Configuration menu
    Copy the full SHA
    73aaf0e View commit details
    Browse the repository at this point in the history