Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix flaky test-child-process-pass-fd on Fedora 24 #17598

Closed
wants to merge 1 commit into from
Closed

test: fix flaky test-child-process-pass-fd on Fedora 24 #17598

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Dec 11, 2017 •
edited
Loading

test-child-process-pass-fd needs to launch many processes
simultaneously. On Fedora 24, this can result in EAGAIN "Resource
temporarily unavailable" errors. When this occurs, simply try to launch
a worker again.

Fixes: #17589

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test child_process

@Trott Trott added the wip Issues and PRs that are still a work in progress. label Dec 11, 2017
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Dec 11, 2017
@Trott
Copy link
Member Author

Trott commented Dec 11, 2017

Stress test against master (hopefully shows test failing): https://ci.nodejs.org/job/node-stress-single-test/1563/nodes=fedora24/console

Stress test against this pull request: https://ci.nodejs.org/job/node-stress-single-test/1564/nodes=fedora24/console

@Trott
Copy link
Member Author

Trott commented Dec 11, 2017 •
edited
Loading

Argh, just noticed something I should have looked at before: This problem does not happen on the Digital Ocean host, just the Rackspace host (which is probably provisioned with fewer resources). I will have to re-run the one of the stress tests.

@Trott
Copy link
Member Author

Trott commented Dec 11, 2017

Oh, neat-o, I guess...once the stress test fails, it then fails again and again and again. Stress test for master is red, so that at least confirms the problem.

@Trott
Copy link
Member Author

Trott commented Dec 11, 2017

Re-running stress test against this PR using Rackspace:

https://ci.nodejs.org/job/node-stress-single-test/1565/nodes=fedora24/

@Trott
Copy link
Member Author

Trott commented Dec 11, 2017 •
edited
Loading

Stress test for this PR still failed with "Resource temporarily unavailable". More work to be done...

@Trott
Copy link
Member Author

Trott commented Dec 11, 2017

OK, more changes, trying again....

CI stress test: https://ci.nodejs.org/job/node-stress-single-test/1566/nodes=fedora24/console

@Trott
test: fix flaky test-child-process-pass-fd
529f000 
test-child-process-pass-fd needs to launch many processes
simultaneously. On Fedora 24, this can result in EAGAIN "Resource
temporarily unavailable" errors. When this occurs, simply try to launch
a worker again.

Fixes: nodejs#17589
@Trott
Copy link
Member Author

Trott commented Dec 11, 2017

Stress test against this PR is looking very good: 9392 successes so far without a failure. I've rebased against master, squashed, written a better commit message and force pushed. Will wait for stress test to finish before running a full CI...removing in progress label.

@Trott Trott removed the wip Issues and PRs that are still a work in progress. label Dec 11, 2017
@Trott Trott changed the title wip fix flaky test-child-process-pass-fd test: fix flaky test-child-process-pass-fd on Fedora 24 Dec 11, 2017
@Trott Trott added the child_process Issues and PRs related to the child_process subsystem. label Dec 11, 2017
@Trott
Copy link
Member Author

Trott commented Dec 12, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/12052/

@Trott
Copy link
Member Author

Trott commented Dec 12, 2017

@nodejs/testing

This was referenced Dec 12, 2017
Closed
Closed
@gibfahn
Copy link
Member

gibfahn commented Dec 12, 2017

LGTM as is, but might it be it worth adding a delay before trying to fork again?

BridgeAR
BridgeAR approved these changes Dec 12, 2017
View reviewed changes
Copy link
Member

@BridgeAR BridgeAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I agree with @gibfahn that a delay would be good.

@Trott
Copy link
Member Author

Trott commented Dec 13, 2017

Landed in d64b0a8

@Trott Trott closed this Dec 13, 2017
Trott added a commit to Trott/io.js that referenced this pull request Dec 13, 2017
@Trott
test: fix flaky test-child-process-pass-fd
d64b0a8 
test-child-process-pass-fd needs to launch many processes
simultaneously. On Fedora 24, this can result in EAGAIN "Resource
temporarily unavailable" errors. When this occurs, simply try to launch
a worker again.

PR-URL: nodejs#17598
Fixes: nodejs#17589
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jan 8, 2018
@Trott @MylesBorins
test: fix flaky test-child-process-pass-fd
6cb4cc2 
test-child-process-pass-fd needs to launch many processes
simultaneously. On Fedora 24, this can result in EAGAIN "Resource
temporarily unavailable" errors. When this occurs, simply try to launch
a worker again.

PR-URL: #17598
Fixes: #17589
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Jan 10, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Jan 22, 2018
@Trott @MylesBorins
test: fix flaky test-child-process-pass-fd
a304206 
test-child-process-pass-fd needs to launch many processes
simultaneously. On Fedora 24, this can result in EAGAIN "Resource
temporarily unavailable" errors. When this occurs, simply try to launch
a worker again.

PR-URL: #17598
Fixes: #17589
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jan 22, 2018
@Trott @MylesBorins
test: fix flaky test-child-process-pass-fd
fcc5b99 
test-child-process-pass-fd needs to launch many processes
simultaneously. On Fedora 24, this can result in EAGAIN "Resource
temporarily unavailable" errors. When this occurs, simply try to launch
a worker again.

PR-URL: #17598
Fixes: #17589
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Jan 24, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Feb 11, 2018
@Trott @MylesBorins
test: fix flaky test-child-process-pass-fd
be8c371 
test-child-process-pass-fd needs to launch many processes
simultaneously. On Fedora 24, this can result in EAGAIN "Resource
temporarily unavailable" errors. When this occurs, simply try to launch
a worker again.

PR-URL: #17598
Fixes: #17589
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 12, 2018
@Trott @MylesBorins
test: fix flaky test-child-process-pass-fd
22bc6a1 
test-child-process-pass-fd needs to launch many processes
simultaneously. On Fedora 24, this can result in EAGAIN "Resource
temporarily unavailable" errors. When this occurs, simply try to launch
a worker again.

PR-URL: #17598
Fixes: #17589
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 13, 2018
@Trott @MylesBorins
test: fix flaky test-child-process-pass-fd
fb0bd8a 
test-child-process-pass-fd needs to launch many processes
simultaneously. On Fedora 24, this can result in EAGAIN "Resource
temporarily unavailable" errors. When this occurs, simply try to launch
a worker again.

PR-URL: #17598
Fixes: #17589
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
@Trott Trott deleted the fixit-maybe branch January 13, 2022 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gibfahn gibfahn gibfahn approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@santigimeno santigimeno santigimeno approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
child_process Issues and PRs related to the child_process subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

investigate flaky tests on fedora 24
8 participants
@Trott @gibfahn @jasnell @santigimeno @gireeshpunathil @BridgeAR @MylesBorins @nodejs-github-bot