Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: mock dns lookup function in parallel tests #17296

Closed
wants to merge 2 commits into from
Closed

test: mock dns lookup function in parallel tests #17296

wants to merge 2 commits into from

Commits on Nov 25, 2017

  1. test: add common.dns.errorLookupMock

    @joyeecheung
    joyeecheung committed Nov 25, 2017
    Configuration menu
    Copy the full SHA
    452c4b8 View commit details
    Browse the repository at this point in the history

  2. test: mock the lookup function in parallel tests 

    These tests should not make any DNS calls. The lookup would fail
when the DNS requests are hijacked and time out instead of erroring
out.
    @joyeecheung
    joyeecheung committed Nov 25, 2017
    Configuration menu
    Copy the full SHA
    a5403ec View commit details
    Browse the repository at this point in the history