Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http2: only schedule write when necessary #17183

Closed
wants to merge 4 commits into from
Closed

http2: only schedule write when necessary #17183

wants to merge 4 commits into from

Commits on Nov 21, 2017

  1. src: add optional keep-alive object to SetImmediate 

    Adds the possibility to keep a strong persistent reference to
a JS object while a `SetImmediate()` call is in effect.
    @addaleax
    addaleax committed Nov 21, 2017
    Configuration menu
    Copy the full SHA
    d5033aa View commit details
    Browse the repository at this point in the history

  2. http2: don't call into JS from GC 

    Calling into JS land from GC is not allowed, so delay
the resolution of pending pings when a session is destroyed.
    @addaleax
    addaleax committed Nov 21, 2017
    Configuration menu
    Copy the full SHA
    1e3b395 View commit details
    Browse the repository at this point in the history

  3. http2: only schedule write when necessary 

    Introduce an `Http2Scope` class that, when it goes out of scope,
checks whether a write to the network is desired by nghttp2.
If that is the case, schedule a write using `SetImmediate()`
rather than a custom per-session libuv handle.
    @addaleax
    addaleax committed Nov 21, 2017
    Configuration menu
    Copy the full SHA
    0e14510 View commit details
    Browse the repository at this point in the history

  4. [squash] jasnell & TimothyGu comments

    @addaleax
    addaleax committed Nov 21, 2017
    Configuration menu
    Copy the full SHA
    02c7022 View commit details
    Browse the repository at this point in the history