Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: implement v8::TaskRunner API in NodePlatform #17134

Closed
wants to merge 5 commits into from
Closed

src: implement v8::TaskRunner API in NodePlatform #17134

wants to merge 5 commits into from

Commits on Nov 21, 2017

  1. deps: cherry-pick c690f54d95802 from V8 upstream 

    Original commit message:

    [platform] Add TaskRunner to the platform API

    With the existing platform API it is not possible to post foreground
    tasks from background tasks. This is, however, required to implement
    asynchronous compilation for WebAssembly. With this CL we add the
    concept of a TaskRunner to the platform API. The TaskRunner contains
    all data needed to post a foreground task and can be used both from a
    foreground task and a background task. Eventually the TaskRunner should
    replace the existing API.

    In addition, this CL contains a default implementation of the
    TaskRunner. This implementation has tempory workaround for platforms
    which do not provide a TaskRunner implementation yet. This default
    implementation should be deleted again when all platforms provide a
    TaskRunner implementation.

    [email protected]

    Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng
    Change-Id: I6ea4a1c9da1eb9a19e8ce8f2163000dbc2598802
    Reviewed-on: https://chromium-review.googlesource.com/741588
    Commit-Queue: Andreas Haas <[email protected]>
    Reviewed-by: Ross McIlroy <[email protected]>
    Cr-Commit-Position: refs/heads/master@{nodejs#49041}

Refs: v8/v8@c690f54
    @addaleax
    addaleax committed Nov 21, 2017
    Configuration menu
    Copy the full SHA
    27f97c7 View commit details
    Browse the repository at this point in the history

  2. deps: cherry-pick 98c40a4bae915 from V8 upstream 

    Original commit message:

    [platform] Return task runners as shared_ptr

    At the moment, task runners are returned as unique_ptr. This is
    inconvenient, however. In all implementations I did, the platform holds
    a shared pointer of the task runner and wraps it in a wrapper class just
    to return it as a unique_ptr. With this CL the platform API is changed
    to return a shared_ptr directly.

    [email protected]

    Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng
    Change-Id: Ide278db855199ea239ad0ae14d97fd17349dac8c
    Reviewed-on: https://chromium-review.googlesource.com/768867
    Commit-Queue: Andreas Haas <[email protected]>
    Reviewed-by: Ross McIlroy <[email protected]>
    Cr-Commit-Position: refs/heads/master@{nodejs#49366}

Refs: v8/v8@98c40a4
    @addaleax
    addaleax committed Nov 21, 2017
    Configuration menu
    Copy the full SHA
    d2848bb View commit details
    Browse the repository at this point in the history

  3. src: implement v8::TaskRunner API in NodePlatform 

    V8 is switching APIs for scheduling tasks. Implement the new APIs.

Fixes: nodejs/node-v8#24
Refs: v8/v8@c690f54
    @addaleax
    addaleax committed Nov 21, 2017
    Configuration menu
    Copy the full SHA
    8be600b View commit details
    Browse the repository at this point in the history

  4. [squash] gahaas nit

    @addaleax
    addaleax committed Nov 21, 2017
    Configuration menu
    Copy the full SHA
    2cd135b View commit details
    Browse the repository at this point in the history

  5. [squash] UNREACHABLE(); all the things

    @addaleax
    addaleax committed Nov 21, 2017
    1 Configuration menu
    Copy the full SHA
    9bd517e View commit details
    Browse the repository at this point in the history