Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: concatenated string to template string #16925

Closed
wants to merge 1 commit into from
Closed

lib: concatenated string to template string #16925

wants to merge 1 commit into from

Conversation

Nayanadask
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

This is my first node.js PR. Please review it.

@nodejs-github-bot nodejs-github-bot added the http Issues or PRs related to the http subsystem. label Nov 10, 2017
@gireeshpunathil gireeshpunathil added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 10, 2017
@danbev
Copy link
Contributor

danbev commented Nov 10, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/11336/

@fhinkel
Copy link
Member

fhinkel commented Nov 11, 2017

CI failures unrelated.

@Nayanadask Thanks so much for your first commit 🎉. Landed as ef3776a

@fhinkel fhinkel closed this Nov 11, 2017
fhinkel pushed a commit that referenced this pull request Nov 11, 2017
@Nayanadask @fhinkel
lib: change concatenated string to template
ef3776a 
PR-URL: #16925
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
evanlucas pushed a commit that referenced this pull request Nov 13, 2017
@Nayanadask @evanlucas
lib: change concatenated string to template
678e738 
PR-URL: #16925
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
@evanlucas evanlucas mentioned this pull request Nov 13, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Nov 17, 2017
@Nayanadask @MylesBorins
lib: change concatenated string to template
28f0360 
PR-URL: #16925
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
@MylesBorins
Copy link
Contributor

Have landed this on 8.x but opted to skip for 6.x as I'm unsure if template strings are optimized in that release stream

@gibfahn gibfahn mentioned this pull request Nov 21, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@tniessen tniessen tniessen approved these changes

@cjihrig cjihrig cjihrig approved these changes

@jasnell jasnell jasnell approved these changes

@danbev danbev danbev approved these changes

@fhinkel fhinkel fhinkel approved these changes

Assignees
No one assigned
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. http Issues or PRs related to the http subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@Nayanadask @danbev @fhinkel @MylesBorins @jasnell @cjihrig @tniessen @gireeshpunathil @nodejs-github-bot