doc: clarify the prerequisites for building with VS2017 #16903
Conversation
nodejs-github-bot
added
build
|
@nodejs/platform-windows I'm going to land this in 24 hours if there are no objections. |
There was a problem hiding this comment.
The list of components that was here was exactly what was needed when those lines landed, anything else was pulled as dependencies. The installer changed, so referring to workloads instead makes more sense. Having a minimal list would be very useful for some users, but since it may change over time it's better to have this.
|
FYI this matches this screenshot of the installer I took back in September:
|
|
We should find a way to follow MSVS installer updates. ATM I only track |
* "Edition" is ambiguous. For example, Visual Studio Team Explorer 2017 is listed under "Visual Studio 2017", but Build Tools for Visual Studio 2017 is listed under "Other Tools and Frameworks". * The listed required components are insufficient. VS2017 also needs "Visual Studio C++ core features", and Build Tools also needs "Visual C++ Build Tools core features". * Installing the workload with the default optional components takes up only about 1GB more space than the minimal set of components, but saves scrolling through the long list of individual components. PR-URL: #16903 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: João Reis <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Richard Lau <[email protected]>
|
Landed in ff21851. |
|
@addaleax do you remember what was missing? Did you base your setup on the old instructions? |
|
@refack Uh… This is partly from memory, but it was something like msbuild complaining about |
* "Edition" is ambiguous. For example, Visual Studio Team Explorer 2017 is listed under "Visual Studio 2017", but Build Tools for Visual Studio 2017 is listed under "Other Tools and Frameworks". * The listed required components are insufficient. VS2017 also needs "Visual Studio C++ core features", and Build Tools also needs "Visual C++ Build Tools core features". * Installing the workload with the default optional components takes up only about 1GB more space than the minimal set of components, but saves scrolling through the long list of individual components. PR-URL: #16903 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: João Reis <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Richard Lau <[email protected]>
* "Edition" is ambiguous. For example, Visual Studio Team Explorer 2017 is listed under "Visual Studio 2017", but Build Tools for Visual Studio 2017 is listed under "Other Tools and Frameworks". * The listed required components are insufficient. VS2017 also needs "Visual Studio C++ core features", and Build Tools also needs "Visual C++ Build Tools core features". * Installing the workload with the default optional components takes up only about 1GB more space than the minimal set of components, but saves scrolling through the long list of individual components. PR-URL: #16903 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: João Reis <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Richard Lau <[email protected]>
|
Landed on 8.x but not 6.x If I recall we don't support VS2017 on 6.x, please correct me if mistaken |
|
@MylesBorins correct. |
is listed under "Visual Studio 2017", but Build Tools for Visual
Studio 2017 is listed under "Other Tools and Frameworks".
"Visual Studio C++ core features", and Build Tools also needs
"Visual C++ Build Tools core features".
only about 1GB more space than the minimal set of components, but
saves scrolling through the long list of individual components.
Checklist
Affected core subsystem(s)
doc