Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: replace string concetation with template literals #16801

Closed
wants to merge 1 commit into from
Closed

tools: replace string concetation with template literals #16801

wants to merge 1 commit into from

Conversation

PatrickHeneise
Copy link

Replace string concatenation in tools/doc/html.js with template literals.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. tools Issues and PRs related to the tools directory. labels Nov 6, 2017
@Trott
Copy link
Member

Trott commented Nov 6, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/11222/

vsemozhetbyt
vsemozhetbyt reviewed Nov 6, 2017
View reviewed changes
tools/doc/html.js
@@ -518,7 +518,7 @@ function getId(text) {
text = text.replace(/^_+|_+$/, '');
text = text.replace(/^([^a-z])/, '_$1');
if (idCounters.hasOwnProperty(text)) {
text += '_' + (++idCounters[text]);
text += `_${(++idCounters[text])}`;
Copy link
Contributor

@vsemozhetbyt vsemozhetbyt Nov 6, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A nit (this can be done by whoever will land the PR): parentheses seem redundant now, this can simply be:

    text += `_${++idCounters[text]}`;

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I missed this comment while landing. Doesn't seem worth force-pushing or doing an additional commit at this point to me, although if someone opens a PR for it, sure, I'm OK with that.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Trott pushed a commit to Trott/io.js that referenced this pull request Nov 6, 2017
@Trott
tools: replace string concetation with templates
94fb298 
Replace string concatenation in tools/doc/html.js with template
literals.

PR-URL: nodejs#16801
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@Trott
Copy link
Member

Trott commented Nov 6, 2017

Landed in 94fb298.

Thanks for the contribution! 🎉

@Trott Trott closed this Nov 6, 2017
@Trott Trott added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 6, 2017
@vsemozhetbyt vsemozhetbyt mentioned this pull request Nov 6, 2017
Closed
2 tasks
cjihrig pushed a commit to cjihrig/node that referenced this pull request Nov 6, 2017
@cjihrig
tools: replace string concetation with templates
422d315 
Replace string concatenation in tools/doc/html.js with template
literals.

PR-URL: nodejs#16801
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@cjihrig cjihrig mentioned this pull request Nov 6, 2017
Merged
Trott pushed a commit to Trott/io.js that referenced this pull request Nov 6, 2017
@vsemozhetbyt @Trott
tools: remove unneeded parentheses in doc/html.js
74d9dc2 
PR-URL: nodejs#16845
Ref: nodejs#16801 (comment)
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
cjihrig pushed a commit to cjihrig/node that referenced this pull request Nov 7, 2017
@vsemozhetbyt @cjihrig
tools: remove unneeded parentheses in doc/html.js
e9396d2 
PR-URL: nodejs#16845
Ref: nodejs#16801 (comment)
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 16, 2017
@MylesBorins
tools: replace string concetation with templates
75fb2f7 
Replace string concatenation in tools/doc/html.js with template
literals.

PR-URL: #16801
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 16, 2017
@MylesBorins
tools: replace string concetation with templates
40fa970 
Replace string concatenation in tools/doc/html.js with template
literals.

PR-URL: #16801
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 16, 2017
@vsemozhetbyt @MylesBorins
tools: remove unneeded parentheses in doc/html.js
9b65fe4 
PR-URL: #16845
Ref: #16801 (comment)
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 16, 2017
@vsemozhetbyt @MylesBorins
tools: remove unneeded parentheses in doc/html.js
cb08f5d 
PR-URL: #16845
Ref: #16801 (comment)
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Nov 21, 2017
Merged
@gibfahn gibfahn mentioned this pull request Nov 21, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Nov 21, 2017
@MylesBorins
tools: replace string concetation with templates
afe6440 
Replace string concatenation in tools/doc/html.js with template
literals.

PR-URL: #16801
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 21, 2017
@vsemozhetbyt @MylesBorins
tools: remove unneeded parentheses in doc/html.js
37044d3 
PR-URL: #16845
Ref: #16801 (comment)
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 28, 2017
@MylesBorins
tools: replace string concetation with templates
d165d3f 
Replace string concatenation in tools/doc/html.js with template
literals.

PR-URL: #16801
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 28, 2017
@vsemozhetbyt @MylesBorins
tools: remove unneeded parentheses in doc/html.js
f3749d7 
PR-URL: #16845
Ref: #16801 (comment)
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

@cjihrig cjihrig cjihrig approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

Assignees
No one assigned
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. doc Issues and PRs related to the documentations. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@PatrickHeneise @Trott @cjihrig @gireeshpunathil @vsemozhetbyt @MylesBorins @nodejs-github-bot