Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add simple extra debugging to flaky test (async-wrap-uncaughtexception) #16757

Closed
wants to merge 4 commits into from

Conversation

addaleax
Copy link
Member

@addaleax addaleax commented Nov 4, 2017

Refs: #16210

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

just fyi, /cc @jasnell @refack @Trott

@addaleax addaleax added async_hooks Issues and PRs related to the async hooks subsystem. test Issues and PRs related to the tests. labels Nov 4, 2017
@addaleax
Copy link
Member Author

addaleax commented Nov 4, 2017

@addaleax
Copy link
Member Author

addaleax commented Nov 4, 2017

Doesn’t seem to do the trick. The “good” news here seems to be that this fails on linuxone as well, which should get us better stress testing I guess…?

So here’s a stress test to get an idea of the linuxone failure rate: https://ci.nodejs.org/job/node-stress-single-test/1540/nodes=rhel72-s390x/

@addaleax addaleax added the wip Issues and PRs that are still a work in progress. label Nov 4, 2017
@addaleax addaleax force-pushed the awu-debug1 branch 2 times, most recently from 5a6525c to 2e9ae7c Compare November 4, 2017 21:20
@addaleax
Copy link
Member Author

addaleax commented Nov 4, 2017

Okay, it’s failing 100 % of the time on linuxone now. Awesome? I guess? Let’s run some things and keep track in this comment so I don’t forget what I already tried out:

I’ll be closing this and opening a PR with what I think is a reasonable fix. Yay!

@addaleax addaleax closed this Nov 4, 2017
@addaleax addaleax deleted the awu-debug1 branch November 4, 2017 21:28
@refack
Copy link
Contributor

refack commented Nov 4, 2017

So it's a combination of the pref_hooks added in 8.5.0 & V8 6.1 updated in 8.7.0... (my assumption since locally I can repro 100% with the Windows.64 official binary, and couldn't repro with 8.6.0)

@addaleax
Copy link
Member Author

addaleax commented Nov 4, 2017

@refack Yup, I assume that’s what’s happening. My suggestion for a fix is in #16758, but if you think something else resolves the problem better, I’ll gladly take it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
async_hooks Issues and PRs related to the async hooks subsystem. test Issues and PRs related to the tests. wip Issues and PRs that are still a work in progress.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants