-
Notifications
You must be signed in to change notification settings - Fork 29.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add simple extra debugging to flaky test (async-wrap-uncaughtexception) #16757
Conversation
Doesn’t seem to do the trick. The “good” news here seems to be that this fails on linuxone as well, which should get us better stress testing I guess…? So here’s a stress test to get an idea of the linuxone failure rate: https://ci.nodejs.org/job/node-stress-single-test/1540/nodes=rhel72-s390x/ |
5a6525c
to
2e9ae7c
Compare
Okay, it’s failing 100 % of the time on linuxone now. Awesome? I guess? Let’s run some things and keep track in this comment so I don’t forget what I already tried out:
I’ll be closing this and opening a PR with what I think is a reasonable fix. Yay! |
So it's a combination of the pref_hooks added in 8.5.0 & V8 6.1 updated in 8.7.0... (my assumption since locally I can repro 100% with the Windows.64 official binary, and couldn't repro with 8.6.0) |
Refs: #16210
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passesAffected core subsystem(s)
test
just fyi, /cc @jasnell @refack @Trott