Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: disable hooks before removing listeners #16739

Closed
wants to merge 1 commit into from
Closed

test: disable hooks before removing listeners #16739

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Nov 4, 2017

Locally, this seems to fix #16210 but will it fix it in CI?

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

@Trott Trott added the wip Issues and PRs that are still a work in progress. label Nov 4, 2017
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Nov 4, 2017
@Trott
Copy link
Member Author

Trott commented Nov 4, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/11183/

@Trott
Copy link
Member Author

Trott commented Nov 4, 2017

Nope.

@Trott Trott closed this Nov 4, 2017
@Trott Trott deleted the disable-hooks branch January 13, 2022 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
test Issues and PRs related to the tests. wip Issues and PRs that are still a work in progress.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Flaky test-async-wrap-uncaughtexception
2 participants
@Trott @nodejs-github-bot