-
Notifications
You must be signed in to change notification settings - Fork 30.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tools: custom eslint autofix for inspector-check.js #16646
Closed
shobhitchittora
wants to merge
4
commits into
nodejs:master
from
shobhitchittora:inspector-check-fix
Closed
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
0e860d0
tools: custom eslint autofix for inspector-check.js
shobhitchittora 4afc45d
tools: custom eslint autofix for inspector-check.js
shobhitchittora c4b5e8b
tools: custom eslint autofix for inspector-check.js
shobhitchittora 3b1ce16
tools: custom eslint autofix for inspector-check.js
shobhitchittora File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -24,6 +24,16 @@ module.exports.isBinding = function(node, modules) { | |
} | ||
}; | ||
|
||
/** | ||
* Return true if common module is required | ||
* in AST Node under inspection | ||
*/ | ||
var commonModuleRegExp = new RegExp(/^(\.\.\/)*common(\.js)?$/); | ||
module.exports.isCommonModule = function(node) { | ||
return node.callee.name === 'require' && | ||
commonModuleRegExp.test(node.arguments[0].value); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Here the access to the first argument has to be guarded. In case a node has no arguments, this will trigger an error. So please add a |
||
}; | ||
|
||
/** | ||
* Returns true is the node accesses any property in the properties | ||
* array on the 'common' object. | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please indent the last two lines by two spaces? :-)