Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: remove empty comments in http2 tests #16631

Closed
wants to merge 1 commit into from
Closed

test: remove empty comments in http2 tests #16631

wants to merge 1 commit into from

Conversation

gibfahn
Copy link
Member

@gibfahn gibfahn commented Oct 31, 2017

I assume they aren't meant to be there.

Refs: #15685

cc/ @jasnell

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test, http2

@gibfahn
test: remove empty comments in http2 tests
5e1725b 
I assume they aren't meant to be there.

Refs: nodejs#15685
@gibfahn gibfahn added http2 Issues or PRs related to the http2 subsystem. test Issues and PRs related to the tests. labels Oct 31, 2017
MylesBorins
MylesBorins approved these changes Oct 31, 2017
View reviewed changes
Copy link
Contributor

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

MylesBorins pushed a commit that referenced this pull request Oct 31, 2017
@gibfahn @MylesBorins
test: remove empty comments in http2 tests
889f42a 
I assume they aren't meant to be there.

PR-URL: #16631
Refs: #15685
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@MylesBorins
Copy link
Contributor

landed in 889f42a

@gibfahn gibfahn mentioned this pull request Oct 31, 2017
Merged
@gibfahn gibfahn deleted the empty-comments-8.x branch October 31, 2017 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@MylesBorins MylesBorins MylesBorins approved these changes

@apapirovski apapirovski apapirovski approved these changes

@jasnell jasnell Awaiting requested review from jasnell

Assignees
No one assigned
Labels
http2 Issues or PRs related to the http2 subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gibfahn @MylesBorins @apapirovski @cjihrig @nodejs-github-bot