Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test,lib: remove scatalogical terminology #16599

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/net.js
Original file line number Diff line number Diff line change
Expand Up @@ -321,7 +321,7 @@ function afterShutdown(status, handle, req) {
// if the writable side has ended already, then clean everything
// up.
function onSocketEnd() {
// XXX Should not have to do as much crap in this function.
// XXX Should not have to do as much in this function.
// ended should already be true, since this is called *after*
// the EOF errno and onread has eof'ed
debug('onSocketEnd', this._readableState);
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-async-wrap-uncaughtexception.js
Original file line number Diff line number Diff line change
Expand Up @@ -42,5 +42,5 @@ process.on('uncaughtException', common.mustCall(() => {
require('crypto').randomBytes(1, common.mustCall(() => {
assert.strictEqual(call_id, async_hooks.executionAsyncId());
call_log[1]++;
throw new Error('ah crap');
throw new Error();
}));