Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: explicitly register built-in modules #16565

Closed
wants to merge 1 commit into from
Closed

src: explicitly register built-in modules #16565

wants to merge 1 commit into from
+167 −35

Commits on Nov 13, 2017

  1. src: explicitly register built-in modules 

    Previously, built-in modules are registered before main() via
__attribute__((constructor)) mechanism in GCC and similiar
mechanism in MSVC. This causes some issues when node is built as
static library. Calling module registration function for built-in
modules in node::Init() helps to avoid the issues.

Refs: nodejs#14986 (comment)

Signed-off-by: Yihong Wang <[email protected]>
    @yhwang
    yhwang committed Nov 13, 2017
    Configuration menu
    Copy the full SHA
    73ed18c View commit details
    Browse the repository at this point in the history