Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v4.x backport] Use external headers in addons tests #16550

Closed
wants to merge 1 commit into from
Closed

[v4.x backport] Use external headers in addons tests #16550

wants to merge 1 commit into from

Commits on Nov 28, 2017

  1. test: don't use internal headers in add-on tests 

    There is no real need and it causes endless grief on Windows with some
of the upcoming changes.

PR-URL: nodejs#6734
Backport-PR-URL: nodejs#16550
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
    @bnoordhuis @gibfahn
    bnoordhuis authored and gibfahn committed Nov 28, 2017
    Configuration menu
    Copy the full SHA
    b520c67 View commit details
    Browse the repository at this point in the history