Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add block scoping to test-assert-deep #16532

Closed
wants to merge 1 commit into from
Closed

test: add block scoping to test-assert-deep #16532

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Oct 26, 2017

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test assert

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Oct 26, 2017
@mscdex mscdex added the assert Issues and PRs related to the assert subsystem. label Oct 27, 2017
@gireeshpunathil
Copy link
Member

@Trott - can you please provide a rational ( a one liner may be) for doing this? Is it readability or something else? (such as performance / footprint etc.? are we expecting gc to kick-in between the test run)

@joyeecheung
Copy link
Member

joyeecheung commented Oct 27, 2017 •
edited
Loading

@gireeshpunathil I think it's mostly for readability, also there will be fewer conflicts of variable names.

@joyeecheung
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/11018/

@Trott
Copy link
Member Author

Trott commented Oct 27, 2017

@gireeshpunathil It's primarily to avoid unintentional side effects between test cases. (More can be done.) I'll add that to the commit message.

@Trott
test: add block scoping to test-assert-deep
a6e1740 
Add block scoping to test-assert-deep.js to reduce likelihood of one
test case having side effects that affect another test case.
@Trott Trott force-pushed the block-scope-test-assert-deep branch from 4a711cc to a6e1740 Compare October 27, 2017 16:56
gibfahn
gibfahn approved these changes Oct 28, 2017
View reviewed changes
Copy link
Member

@gibfahn gibfahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find this much easier to read (tests are clearly separated).

@gireeshpunathil
Copy link
Member

thanks @Trott and @joyeecheung for clarifying

@joyeecheung
Copy link
Member

CI failures are unrelated, can go ahead an land this now if we don't want to wait for 72 hours.

tniessen pushed a commit that referenced this pull request Oct 29, 2017
@Trott @tniessen
test: add block scoping to test-assert-deep
203b548 
Add block scoping to test-assert-deep.js to reduce likelihood of one
test case having side effects that affect another test case.

PR-URL: #16532
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
@tniessen
Copy link
Member

Landed in 203b548.

@tniessen tniessen closed this Oct 29, 2017
@jasnell jasnell mentioned this pull request Oct 30, 2017
Merged
gibfahn pushed a commit that referenced this pull request Oct 30, 2017
@Trott @gibfahn
test: add block scoping to test-assert-deep
0ec47de 
Add block scoping to test-assert-deep.js to reduce likelihood of one
test case having side effects that affect another test case.

PR-URL: #16532
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
gibfahn pushed a commit that referenced this pull request Oct 30, 2017
@Trott @gibfahn
test: add block scoping to test-assert-deep
170f2eb 
Add block scoping to test-assert-deep.js to reduce likelihood of one
test case having side effects that affect another test case.

PR-URL: #16532
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
gibfahn pushed a commit that referenced this pull request Oct 31, 2017
@Trott @gibfahn
test: add block scoping to test-assert-deep
a628455 
Add block scoping to test-assert-deep.js to reduce likelihood of one
test case having side effects that affect another test case.

PR-URL: #16532
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
@gibfahn gibfahn mentioned this pull request Oct 31, 2017
Merged
Qard pushed a commit to ayojs/ayo that referenced this pull request Nov 2, 2017
@Trott @Qard
test: add block scoping to test-assert-deep
47debc3 
Add block scoping to test-assert-deep.js to reduce likelihood of one
test case having side effects that affect another test case.

PR-URL: nodejs/node#16532
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Qard pushed a commit to ayojs/ayo that referenced this pull request Nov 2, 2017
@Trott @Qard
test: add block scoping to test-assert-deep
7280e57 
Add block scoping to test-assert-deep.js to reduce likelihood of one
test case having side effects that affect another test case.

PR-URL: nodejs/node#16532
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
addaleax pushed a commit to ayojs/ayo that referenced this pull request Dec 7, 2017
@Trott @addaleax
test: add block scoping to test-assert-deep
c060c87 
Add block scoping to test-assert-deep.js to reduce likelihood of one
test case having side effects that affect another test case.

PR-URL: nodejs/node#16532
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
@Trott Trott deleted the block-scope-test-assert-deep branch January 13, 2022 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@cjihrig cjihrig cjihrig approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

@JungMinu JungMinu JungMinu approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@gibfahn gibfahn gibfahn approved these changes

Assignees
No one assigned
Labels
assert Issues and PRs related to the assert subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.