Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing semicolon #16517

Closed
wants to merge 1 commit into from
Closed

Add missing semicolon #16517

wants to merge 1 commit into from

Conversation

sgallagher
Copy link
Contributor

Typo introduced in 0d50c70

This causes the build to fail when run with debug mode enabled.

Signed-off-by: Stephen Gallagher [email protected]

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

http2 support

@sgallagher
Add missing semicolon
60979f8 
Typo introduced in 0d50c70

Signed-off-by: Stephen Gallagher <[email protected]>
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. dont-land-on-v4.x http2 Issues or PRs related to the http2 subsystem. labels Oct 26, 2017
@jasnell
Copy link
Member

jasnell commented Oct 26, 2017

This shouldn't need to wait the 48 hours to land

mhdawson
mhdawson approved these changes Oct 26, 2017
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@apapirovski
Copy link
Member

I believe @danbev's PR should be backported instead, no? #16432

Also this doesn't seem the right way to deploy to v8.x unless I misunderstood...

@sgallagher
Copy link
Contributor Author

Yes, it appears that other PR is a proper superset of this. I'm withdrawing this PR.

@sgallagher sgallagher closed this Oct 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhdawson mhdawson mhdawson approved these changes

@cjihrig cjihrig cjihrig approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. http2 Issues or PRs related to the http2 subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sgallagher @jasnell @apapirovski @cjihrig @mhdawson @nodejs-github-bot