[v8.x backport] repl: remove internal frames from runtime errors

[lance]

When a user executes code in the REPLServer which generates an
exception, there is no need to display the REPLServer internal
stack frames.

PR-URL: #15351
Reviewed-By: Prince John Wesley [email protected]
Reviewed-By: James M Snell [email protected]
Reviewed-By: Ruben Bridgewater [email protected]

Refs: #9601

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• commit message follows commit guidelines

Affected core subsystem(s)

repl

[lance]

I left make -j4 test unchecked because I am getting two completely unrelated but consistent test failures for async_hooks. Not sure what to make of that.

Local build failure stack traces

/usr/local/opt/python/bin/python2.7 tools/test.py --mode=release -J \
                async-hooks \
                default \
                addons addons-napi \
                doctool known_issues
=== release test-callback-error ===
Path: async-hooks/test-callback-error
start case 1
end case 1: 147.604ms
start case 2
end case 2: 121.808ms
start case 3
end case 3: 8.184ms
Error: test_callback_abort
    at ActivityCollector.initHooks.oninit.common.mustCall (/Users/lanceball/src/node/test/async-hooks/test-callback-error.js:36:45)
    at ActivityCollector.oninit (/Users/lanceball/src/node/test/common/index.js:531:15)
    at ActivityCollector._init (/Users/lanceball/src/node/test/async-hooks/init-hooks.js:185:10)
    at emitInitNative (async_hooks.js:472:43)
    at Object.emitInitScript [as emitInit] (async_hooks.js:388:3)
    at Object. (/Users/lanceball/src/node/test/async-hooks/test-callback-error.js:38:17)
    at Module._compile (module.js:612:30)
    at Object.Module._extensions..js (module.js:623:10)
    at Module.load (module.js:531:32)
    at tryModuleLoad (module.js:494:12)
 1: node::Abort() [/Users/lanceball/src/node/out/Release/node]
 2: node::Chdir(v8::FunctionCallbackInfo const&) [/Users/lanceball/src/node/out/Release/node]
 3: v8::internal::FunctionCallbackArguments::Call(void (*)(v8::FunctionCallbackInfo const&)) [/Users/lanceball/src/node/out/Release/node]
 4: v8::internal::MaybeHandle v8::internal::(anonymous namespace)::HandleApiCallHelper(v8::internal::Isolate*, v8::internal::Handle, v8::internal::Handle, v8::internal::Handle, v8::internal::Handle, v8::internal::BuiltinArguments) [/Users/lanceball/src/node/out/Release/node]
 5: v8::internal::Builtin_Impl_HandleApiCall(v8::internal::BuiltinArguments, v8::internal::Isolate*) [/Users/lanceball/src/node/out/Release/node]
 6: 0x33e31af0463d
Command: out/Release/node /Users/lanceball/src/node/test/async-hooks/test-callback-error.js
=== release test-callback-error ===
Path: async-hooks/test-callback-error
start case 1
end case 1: 122.510ms
start case 2
end case 2: 124.422ms
start case 3
end case 3: 7.740ms
Error: test_callback_abort
    at ActivityCollector.initHooks.oninit.common.mustCall (/Users/lanceball/src/node/test/async-hooks/test-callback-error.js:36:45)
    at ActivityCollector.oninit (/Users/lanceball/src/node/test/common/index.js:531:15)
    at ActivityCollector._init (/Users/lanceball/src/node/test/async-hooks/init-hooks.js:185:10)
    at emitInitNative (async_hooks.js:472:43)
    at Object.emitInitScript [as emitInit] (async_hooks.js:388:3)
    at Object. (/Users/lanceball/src/node/test/async-hooks/test-callback-error.js:38:17)
    at Module._compile (module.js:612:30)
    at Object.Module._extensions..js (module.js:623:10)
    at Module.load (module.js:531:32)
    at tryModuleLoad (module.js:494:12)
 1: node::Abort() [/Users/lanceball/src/node/out/Release/node]
 2: node::Chdir(v8::FunctionCallbackInfo const&) [/Users/lanceball/src/node/out/Release/node]
 3: v8::internal::FunctionCallbackArguments::Call(void (*)(v8::FunctionCallbackInfo const&)) [/Users/lanceball/src/node/out/Release/node]
 4: v8::internal::MaybeHandle v8::internal::(anonymous namespace)::HandleApiCallHelper(v8::internal::Isolate*, v8::internal::Handle, v8::internal::Handle, v8::internal::Handle, v8::internal::Handle, v8::internal::BuiltinArguments) [/Users/lanceball/src/node/out/Release/node]
 5: v8::internal::Builtin_Impl_HandleApiCall(v8::internal::BuiltinArguments, v8::internal::Isolate*) [/Users/lanceball/src/node/out/Release/node]
 6: 0x948e650463d
Command: out/Release/node /Users/lanceball/src/node/test/async-hooks/test-callback-error.js
[04:01|% 100|+ 2007|-   2]: Done
make: *** [test] Error 1

Edit: This has been resolved

[lance]

CI: https://ci.nodejs.org/job/node-test-pull-request/10971/

Edit: several failures - all of which seem to be unrelated.

[gibfahn]

@lance I could be wrong, but doesn't this code come from #14223, which was semver-major?

If so I think you can just drop this bit.

[lance]

@gibfahn good catch! Fixed (I think). I had to add REPLServer.prototype.parseREPLKeyword() back in to repl.js which seems like the best way to deal with this.

New CI: https://ci.nodejs.org/job/node-test-pull-request/11118/

[gibfahn]

Isn't this function already defined here?

node/lib/repl.js

Lines 1053 to 1066 in edb03cb

	/**
	* Used to parse and execute the Node REPL commands.
	*
	* @param {keyword} keyword The command entered to check.
	* @return {Boolean} If true it means don't continue parsing the command.
	*/
	REPLServer.prototype.parseREPLKeyword = function(keyword, rest) {
	var cmd = this.commands[keyword];
	if (cmd) {
	cmd.action.call(this, rest);
	return true;
	}
	return false;
	};

[lance]

Hmm - that's disconcerting enough for me to want to start over on this. I'll take a look..

Update: bad cherry picking on my part. I will fix and push. My apologies.

Don't think function should be declared twice.

[lance]

Another CI after latest push https://ci.nodejs.org/job/node-test-pull-request/11499/

[gibfahn]

CI: https://ci.nodejs.org/job/node-test-commit/14966/

[gibfahn]

CI failures were from the v8.x-staging branch AFAICT.

Landed in 6deae6e

Thanks @lance !