Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: do not include deleted directory #16384

Closed
wants to merge 1 commit into from
Closed

build: do not include deleted directory #16384

wants to merge 1 commit into from

Conversation

maclover7
Copy link
Contributor

deps/uv/src/ares hasn't existed since libuv/libuv@41b1265
(mid 2012).

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

build

@maclover7
build: do not include deleted directory
6e7fad4 
`deps/uv/src/ares` hasn't existed since libuv/libuv@41b1265
(mid 2012).
@nodejs-github-bot nodejs-github-bot added the build Issues and PRs related to build files or the CI. label Oct 22, 2017
@addaleax
Copy link
Member

This shouldn’t need to wait 48 hours

CI to be on the safe side: https://ci.nodejs.org/job/node-test-commit/13373/

(also, congratulations to the round PR number! 😄)

@maclover7
Copy link
Contributor Author

@addaleax would you be willing to land this (I would if I could 😄)

@apapirovski
Copy link
Member

Landed in a82401e

apapirovski pushed a commit that referenced this pull request Oct 25, 2017
@maclover7 @apapirovski
build: do not include deleted directory
a82401e 
`deps/uv/src/ares` hasn't existed since
libuv/libuv@41b1265 (mid 2012).

PR-URL: #16384
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@maclover7 maclover7 deleted the jm-rm-uvares branch October 25, 2017 13:33
addaleax pushed a commit to ayojs/ayo that referenced this pull request Oct 26, 2017
@maclover7 @addaleax
build: do not include deleted directory
f3e1aa0 
`deps/uv/src/ares` hasn't existed since
libuv/libuv@41b1265 (mid 2012).

PR-URL: nodejs/node#16384
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@jasnell jasnell mentioned this pull request Oct 30, 2017
Merged
gibfahn pushed a commit that referenced this pull request Oct 30, 2017
@maclover7 @gibfahn
build: do not include deleted directory
571b8b3 
`deps/uv/src/ares` hasn't existed since
libuv/libuv@41b1265 (mid 2012).

PR-URL: #16384
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
gibfahn pushed a commit that referenced this pull request Oct 31, 2017
@maclover7 @gibfahn
build: do not include deleted directory
22ec800 
`deps/uv/src/ares` hasn't existed since
libuv/libuv@41b1265 (mid 2012).

PR-URL: #16384
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@gibfahn gibfahn mentioned this pull request Oct 31, 2017
Merged
@MylesBorins
Copy link
Contributor

Should this be backported to v6.x-staging? If yes please follow the guide and raise a backport PR, if not let me know or add the dont-land-on label.

addaleax pushed a commit to ayojs/ayo that referenced this pull request Dec 7, 2017
@maclover7 @addaleax
build: do not include deleted directory
e08c659 
`deps/uv/src/ares` hasn't existed since
libuv/libuv@41b1265 (mid 2012).

PR-URL: nodejs/node#16384
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gibfahn gibfahn gibfahn approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@cjihrig cjihrig cjihrig approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

@refack refack refack approved these changes

@apapirovski apapirovski apapirovski approved these changes

Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@maclover7 @addaleax @apapirovski @MylesBorins @refack @jasnell @cjihrig @gireeshpunathil @gibfahn @nodejs-github-bot